Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php

Summary

Maintainability
F
1 wk
Test Coverage

Function preprocess has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

    function preprocess(){

        global $FANNIE_CORRECTION_CASHIER, $FANNIE_CORRECTION_LANE, $FANNIE_CORRECTION_DEPT;
        global $FANNIE_PLUGIN_LIST,$FANNIE_PLUGIN_SETTINGS,$FANNIE_OP_DB;
Severity: Minor
Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File CoopCredInputTool.php has 459 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2010,2013 Whole Foods Co-op, Duluth, MN
    Copyright 2014 West End Food Co-op, Toronto, ON, Canada
Severity: Minor
Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 7 hrs to fix

    Method preprocess has 168 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function preprocess(){

        global $FANNIE_CORRECTION_CASHIER, $FANNIE_CORRECTION_LANE, $FANNIE_CORRECTION_DEPT;
        global $FANNIE_PLUGIN_LIST,$FANNIE_PLUGIN_SETTINGS,$FANNIE_OP_DB;
    Severity: Major
    Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 6 hrs to fix

      Method doInsert has 122 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function doInsert($dtrans,$amount,$department,$cardno,$comment=''){
        global $FANNIE_OP_DB, $FANNIE_TRANS_DB;
        $dbc = FannieDB::get($FANNIE_TRANS_DB);
        $OP = $FANNIE_OP_DB.$dbc->sep();
      Severity: Major
      Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 4 hrs to fix

        Function doInsert has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
        Open

            function doInsert($dtrans,$amount,$department,$cardno,$comment=''){
        global $FANNIE_OP_DB, $FANNIE_TRANS_DB;
        $dbc = FannieDB::get($FANNIE_TRANS_DB);
        $OP = $FANNIE_OP_DB.$dbc->sep();
        Severity: Minor
        Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method finish_content has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function finish_content(){

        global $FANNIE_URL;

        if (!empty($this->errors)) {
        Severity: Minor
        Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 1 hr to fix

          Method form_content has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function form_content(){
        global $FANNIE_URL;

        if (!empty($this->errors)) {
            return "<p style='font-size:1.2em;'>" . $this->errors . "</p>";
          Severity: Minor
          Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 1 hr to fix

            Method confirm_content has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function confirm_content(){

        if (!empty($this->errors)) {
            return "<p style='font-size:1.2em;'>" . $this->errors . "</p>";
        }
            Severity: Minor
            Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 1 hr to fix

              Method doInsert has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  function doInsert($dtrans,$amount,$department,$cardno,$comment=''){
              Severity: Minor
              Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 35 mins to fix

                Avoid too many return statements within this method.
                Open

                                return True;
                Severity: Major
                Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return True;
                  Severity: Major
                  Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return True;
                    Severity: Major
                    Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return True;
                      Severity: Major
                      Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return True;
                        Severity: Major
                        Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return True;
                          Severity: Major
                          Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                return True;
                            Severity: Major
                            Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              return True;
                              Severity: Major
                              Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                return True;
                                Severity: Major
                                Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                  return True;
                                  Severity: Major
                                  Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                    return True;
                                    Severity: Major
                                    Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                              return True;
                                      Severity: Major
                                      Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                return True;
                                        Severity: Major
                                        Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                          return True;
                                          Severity: Major
                                          Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php - About 30 mins to fix

                                            Similar blocks of code found in 2 locations. Consider refactoring.
                                            Open

                                                function doInsert($dtrans,$amount,$department,$cardno,$comment=''){
        global $FANNIE_OP_DB, $FANNIE_TRANS_DB;
        $dbc = FannieDB::get($FANNIE_TRANS_DB);
        $OP = $FANNIE_OP_DB.$dbc->sep();
                                            Severity: Major
                                            Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php and 1 other location - About 6 days to fix
                                            fannie/modules/plugins2.0/CoopCred/membership/CoopCredTransferTool.php on lines 603..735

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 1137.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Identical blocks of code found in 3 locations. Consider refactoring.
                                            Open

                                                    if (FormLib::get_form_value('programID') == "0") {
            $backLabel = _("Return to Member Editor");
            $this->errors .= "<em>" .
                _("Warning: ") . _("The Member does not yet belong to a Program.") .
                "<br />" .
                                            Severity: Major
                                            Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php and 2 other locations - About 1 hr to fix
                                            fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php on lines 99..110
                                            fannie/modules/plugins2.0/CoopCred/membership/CoopCredTransferTool.php on lines 104..115

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 102.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Identical blocks of code found in 2 locations. Consider refactoring.
                                            Open

                                                function getTransNo($emp,$register){
        global $FANNIE_TRANS_DB;
        $dbc = FannieDB::get($FANNIE_TRANS_DB);
        $q = $dbc->prepare("SELECT max(trans_no)
            FROM dtransactions
                                            Severity: Minor
                                            Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php and 1 other location - About 1 hr to fix
                                            fannie/modules/plugins2.0/CoopCred/membership/CoopCredTransferTool.php on lines 582..591

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 100.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            There are no issues that match your filters.

                                            Category
                                            Status