Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php

Summary

Maintainability
F
4 days
Test Coverage

Function preprocess has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    function preprocess(){
        global $FANNIE_PLUGIN_LIST,$FANNIE_PLUGIN_SETTINGS,$FANNIE_OP_DB;
        global $FANNIE_CORRECTION_CASHIER, $FANNIE_CORRECTION_LANE, $FANNIE_CORRECTION_DEPT;

        if (isset($FANNIE_CORRECTION_CASHIER)) {
Severity: Minor
Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method preprocess has 147 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function preprocess(){
        global $FANNIE_PLUGIN_LIST,$FANNIE_PLUGIN_SETTINGS,$FANNIE_OP_DB;
        global $FANNIE_CORRECTION_CASHIER, $FANNIE_CORRECTION_LANE, $FANNIE_CORRECTION_DEPT;

        if (isset($FANNIE_CORRECTION_CASHIER)) {
Severity: Major
Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 5 hrs to fix

    File CoopCredJiggerTool.php has 364 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2010,2013 Whole Foods Co-op, Duluth, MN
    Copyright 2014 West End Food Co-op, Toronto, ON, Canada
    Severity: Minor
    Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 4 hrs to fix

      Method doInsert has 79 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function doInsert($dtrans,$amount,$department,$cardno){
        global $FANNIE_OP_DB, $FANNIE_TRANS_DB;
        $dbc = FannieDB::get($FANNIE_TRANS_DB);
        $OP = $FANNIE_OP_DB.$dbc->sep();
      Severity: Major
      Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 3 hrs to fix

        Method form_content has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function form_content(){
        global $FANNIE_URL;

        if (!empty($this->errors)) {
            return "<p style='font-size:1.2em;'>" . $this->errors . "</p>";
        Severity: Minor
        Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 1 hr to fix

          Method confirm_content has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function confirm_content(){

        if (!empty($this->errors)) {
            return "<p style='font-size:1.2em;'>" . $this->errors . "</p>";
        }
          Severity: Minor
          Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 1 hr to fix

            Function doInsert has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                function doInsert($dtrans,$amount,$department,$cardno){
        global $FANNIE_OP_DB, $FANNIE_TRANS_DB;
        $dbc = FannieDB::get($FANNIE_TRANS_DB);
        $OP = $FANNIE_OP_DB.$dbc->sep();
            Severity: Minor
            Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return True;
            Severity: Major
            Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return True;
              Severity: Major
              Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return True;
                Severity: Major
                Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                      return True;
                  Severity: Major
                  Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return True;
                    Severity: Major
                    Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                          return True;
                      Severity: Major
                      Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return True;
                        Severity: Major
                        Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return True;
                          Severity: Major
                          Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return True;
                            Severity: Major
                            Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              return True;
                              Severity: Major
                              Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php - About 30 mins to fix

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                        if ($this->mode == 'init'){
            $memNum = FormLib::get_form_value('memIN');
            if ($memNum != 0) {
                $q = $dbc->prepare("SELECT FirstName,LastName
                    FROM {$OP}custdata
                                Severity: Major
                                Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php and 1 other location - About 3 hrs to fix
                                fannie/modules/plugins2.0/CoopCred/membership/CoopCredTransferTool.php on lines 157..173

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 155.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 3 locations. Consider refactoring.
                                Open

                                        if (FormLib::get_form_value('programID') == "0") {
            $backLabel = _("Return to Member Editor");
            $this->errors .= "<em>" .
                _("Warning: ") . _("The Member does not yet belong to a Program.") .
                "<br />" .
                                Severity: Major
                                Found in fannie/modules/plugins2.0/CoopCred/membership/CoopCredJiggerTool.php and 2 other locations - About 1 hr to fix
                                fannie/modules/plugins2.0/CoopCred/membership/CoopCredInputTool.php on lines 99..110
                                fannie/modules/plugins2.0/CoopCred/membership/CoopCredTransferTool.php on lines 104..115

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 102.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status