Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/CoopCred/reports/MemberSummary/MemberSummaryReport.php

Summary

Maintainability
F
5 days
Test Coverage

Method fetch_report_data has 214 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function fetch_report_data(){

        //global $FANNIE_TRANS_DB,
        global $FANNIE_OP_DB, $FANNIE_URL;
        global $FANNIE_PLUGIN_SETTINGS;
Severity: Major
Found in fannie/modules/plugins2.0/CoopCred/reports/MemberSummary/MemberSummaryReport.php - About 1 day to fix

    File MemberSummaryReport.php has 498 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op
    Severity: Minor
    Found in fannie/modules/plugins2.0/CoopCred/reports/MemberSummary/MemberSummaryReport.php - About 7 hrs to fix

      Function fetch_report_data has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
      Open

          function fetch_report_data(){

        //global $FANNIE_TRANS_DB,
        global $FANNIE_OP_DB, $FANNIE_URL;
        global $FANNIE_PLUGIN_SETTINGS;
      Severity: Minor
      Found in fannie/modules/plugins2.0/CoopCred/reports/MemberSummary/MemberSummaryReport.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method form_content has 90 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function form_content(){

        global $FANNIE_PLUGIN_SETTINGS;

        $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['CoopCredDatabase']);
      Severity: Major
      Found in fannie/modules/plugins2.0/CoopCred/reports/MemberSummary/MemberSummaryReport.php - About 3 hrs to fix

        Function preprocess has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
        Open

            function preprocess(){

        global $FANNIE_URL,$FANNIE_PLUGIN_LIST,$FANNIE_PLUGIN_SETTINGS;

        if (!isset($FANNIE_PLUGIN_LIST) || !in_array('CoopCred', $FANNIE_PLUGIN_LIST)) {
        Severity: Minor
        Found in fannie/modules/plugins2.0/CoopCred/reports/MemberSummary/MemberSummaryReport.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method preprocess has 67 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function preprocess(){

        global $FANNIE_URL,$FANNIE_PLUGIN_LIST,$FANNIE_PLUGIN_SETTINGS;

        if (!isset($FANNIE_PLUGIN_LIST) || !in_array('CoopCred', $FANNIE_PLUGIN_LIST)) {
        Severity: Major
        Found in fannie/modules/plugins2.0/CoopCred/reports/MemberSummary/MemberSummaryReport.php - About 2 hrs to fix

          Function form_content has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              function form_content(){

        global $FANNIE_PLUGIN_SETTINGS;

        $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['CoopCredDatabase']);
          Severity: Minor
          Found in fannie/modules/plugins2.0/CoopCred/reports/MemberSummary/MemberSummaryReport.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method calculate_footers has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function calculate_footers($data){
        $sumPayments = 0.0;
        $sumCharges = 0.0;
        $sumNet = 0.0;
        if ($this->reportType == "detail") {
          Severity: Minor
          Found in fannie/modules/plugins2.0/CoopCred/reports/MemberSummary/MemberSummaryReport.php - About 1 hr to fix

            Method report_description_content has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function report_description_content(){
        /* Each line of description is an element of this array.
         * At output <br /> will be prefixed unless the element starts with
         *  an HTML tag
         */
            Severity: Minor
            Found in fannie/modules/plugins2.0/CoopCred/reports/MemberSummary/MemberSummaryReport.php - About 1 hr to fix

              Avoid too many return statements within this method.
              Open

                      return True;
              Severity: Major
              Found in fannie/modules/plugins2.0/CoopCred/reports/MemberSummary/MemberSummaryReport.php - About 30 mins to fix

                Function calculate_footers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    function calculate_footers($data){
        $sumPayments = 0.0;
        $sumCharges = 0.0;
        $sumNet = 0.0;
        if ($this->reportType == "detail") {
                Severity: Minor
                Found in fannie/modules/plugins2.0/CoopCred/reports/MemberSummary/MemberSummaryReport.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    function form_content(){

        global $FANNIE_PLUGIN_SETTINGS;

        $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['CoopCredDatabase']);
                Severity: Major
                Found in fannie/modules/plugins2.0/CoopCred/reports/MemberSummary/MemberSummaryReport.php and 1 other location - About 1 day to fix
                fannie/modules/plugins2.0/CoopCred/reports/Liability/LiabilityReport.php on lines 512..609

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 258.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status