Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php

Summary

Maintainability
F
3 days
Test Coverage

Method drawPDF has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function drawPDF()
    {
        $pdf = $this->createPDF();
        $dbc = FannieDB::get(FannieConfig::config('OP_DB'));
        $basicP = $dbc->prepare("SELECT
Severity: Major
Found in fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php - About 2 hrs to fix

    Function getTopImage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getTopImage($item)
    {
        if (strstr($item['batchName'], 'Co-op Deals') && !strstr($item['batchName'], 'TPR')) {
            return __DIR__ . '/noauto/images/codeals_top_12.png';
        } elseif (!empty($item['batchName'])) {
    Severity: Minor
    Found in fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getBottomImage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getBottomImage($item)
    {
        if (strstr($item['batchName'], 'Co-op Deals') && !strstr($item['batchName'], 'TPR')) {
            return __DIR__ . '/cd_line_16.png';
        } elseif (!empty($item['batchName'])) {
    Severity: Minor
    Found in fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return __DIR__ . '/noauto/images/organic_bottom_12.png';
    Severity: Major
    Found in fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return __DIR__ . '/noauto/images/local-bottom.png';
      Severity: Major
      Found in fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return __DIR__ . '/noauto/images/standard_bottom_12.png';
        Severity: Major
        Found in fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return __DIR__ . '/noauto/images/organic_top_12.png';
          Severity: Major
          Found in fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return __DIR__ . '/noauto/images/local-top.png';
            Severity: Major
            Found in fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return __DIR__ . '/noauto/images/standard_top_12.png';
              Severity: Major
              Found in fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if ($count % 16 == 0) {
                $pdf->AddPage();
                // draw tick marks for cutting
                $pdf->Line(2, $height+1.5, 6, $height+1.5);
                $pdf->Line(2, (2*$height)+1.5, 6, (2*$height)+1.5);
                Severity: Major
                Found in fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php and 1 other location - About 2 days to fix
                fannie/modules/plugins2.0/CoopDealsSigns/CoopDeals16UpDarkP.php on lines 38..54

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 438.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    private function getBottomImage($item)
    {
        if (strstr($item['batchName'], 'Co-op Deals') && !strstr($item['batchName'], 'TPR')) {
            return __DIR__ . '/cd_line_16.png';
        } elseif (!empty($item['batchName'])) {
                Severity: Major
                Found in fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php and 1 other location - About 2 hrs to fix
                fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php on lines 86..103

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 140.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    private function getTopImage($item)
    {
        if (strstr($item['batchName'], 'Co-op Deals') && !strstr($item['batchName'], 'TPR')) {
            return __DIR__ . '/noauto/images/codeals_top_12.png';
        } elseif (!empty($item['batchName'])) {
                Severity: Major
                Found in fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php and 1 other location - About 2 hrs to fix
                fannie/modules/plugins2.0/CoopDealsSigns/WfcSmartSigns16UpP.php on lines 105..122

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 140.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status