CORE-POS/IS4C

View on GitHub
fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php

Summary

Maintainability
F
3 days
Test Coverage

Method fetch_report_data has 266 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function fetch_report_data()
    {
        try {
            $month = $this->form->month;
            $year = $this->form->year;
Severity: Major
Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 1 day to fix

    File EOMReport.php has 365 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    use COREPOS\Fannie\API\item\StandardAccounting;
    
    include(__DIR__ . '/../../../../config.php');
    Severity: Minor
    Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 4 hrs to fix

      Function fetch_report_data has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          public function fetch_report_data()
          {
              try {
                  $month = $this->form->month;
                  $year = $this->form->year;
      Severity: Minor
      Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method calculate_footers has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function calculate_footers($data)
          {
              switch($this->multi_counter) {
                  case 1:
                      $this->report_headers[0] = array('Dept#', 'Super#', 'Account#', 'Dept Name', 'Sales');
      Severity: Minor
      Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 1 hr to fix

        Method form_content has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function form_content()
            {
                $opts = array_reduce(range(1, 12), function ($c, $i) { 
                    $lm = date('n', mktime(0,0,0,date('n')-1,1,2000));
                    $sel = $lm == $i ? 'selected' : '';
        Severity: Minor
        Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

                          $sum = array_reduce($data, function($c, $i) { return $c + $i[1]; });
          Severity: Major
          Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return array('Total', '', $sum);
            Severity: Major
            Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              $sum = array_reduce($data, function($c, $i) { return $c + $i[1]; });
              Severity: Major
              Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                $sum = array_reduce($data, function($c, $i) { return $c + $i[4]; });
                Severity: Major
                Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return array('Total', $sum);
                  Severity: Major
                  Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return array('Total', '', '', '', $sum);
                    Severity: Major
                    Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return array('Total', $sum);
                      Severity: Major
                      Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        $sum = array_reduce($data, function($c, $i) { return $c + $i[1]; });
                        Severity: Major
                        Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return array();
                          Severity: Major
                          Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return array('Total', $sum, '');
                            Severity: Major
                            Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              $sum = array_reduce($data, function($c, $i) { return $c + $i[1]; });
                              Severity: Major
                              Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                return array('Total', $sum);
                                Severity: Major
                                Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                  $sum = array_reduce($data, function($c, $i) { return $c + $i[2]; });
                                  Severity: Major
                                  Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php - About 30 mins to fix

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                                case 5:
                                                    $this->report_headers[0] = array('Dept#', 'Super#', 'Account#', 'Dept Name', 'Sales');
                                                    $sum = array_reduce($data, function($c, $i) { return $c + $i[4]; });
                                                    return array('Total', '', '', '', $sum);
                                    Severity: Minor
                                    Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php and 1 other location - About 35 mins to fix
                                    fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php on lines 314..317

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 92.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                                case 1:
                                                    $this->report_headers[0] = array('Dept#', 'Super#', 'Account#', 'Dept Name', 'Sales');
                                                    $sum = array_reduce($data, function($c, $i) { return $c + $i[4]; });
                                                    return array('Total', '', '', '', $sum);
                                    Severity: Minor
                                    Found in fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php and 1 other location - About 35 mins to fix
                                    fannie/modules/plugins2.0/CoreWarehouse/reports/EOMReport.php on lines 330..333

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 92.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    There are no issues that match your filters.

                                    Category
                                    Status