Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php

Summary

Maintainability
F
2 wks
Test Coverage

Method get_id_view has 902 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_id_view()
    {
        $ret = '';
        $ret .= '
Severity: Major
Found in fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php - About 4 days to fix

    File DeliCateringOrdersPage.php has 1245 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php 
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op
    Severity: Major
    Found in fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php - About 3 days to fix

      Function get_id_view has a Cognitive Complexity of 136 (exceeds 5 allowed). Consider refactoring.
      Open

          public function get_id_view()
    {
        $ret = '';
        $ret .= '
      Severity: Minor
      Found in fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php - About 2 days to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_id_confirm_view has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
      Open

          public function get_id_confirm_view()
    {
        
        $ret = '';
        $data = array();
      Severity: Minor
      Found in fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_id_confirm_view has 135 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function get_id_confirm_view()
    {
        
        $ret = '';
        $data = array();
      Severity: Major
      Found in fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php - About 5 hrs to fix

        Method get_review_view has 98 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function get_review_view()
    {
        $ret = "";
        $ret .= '<a class="btn btn-default" href="
            http://key/git/fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php">
        Severity: Major
        Found in fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php - About 3 hrs to fix

          Function get_review_view has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
          Open

              public function get_review_view()
    {
        $ret = "";
        $ret .= '<a class="btn btn-default" href="
            http://key/git/fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php">
          Severity: Minor
          Found in fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method get_view has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function get_view()
    {
        
        $ret = "";
          Severity: Minor
          Found in fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ($_GET as $key => $value) {
            if ($value > 0 && substr($key,0,2) === 'id') {
                $thisUPC = substr($key,2,3);
                $data[$key][$thisUPC] = $value;
            } elseif ($value === 'LG') {
            Severity: Major
            Found in fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php and 1 other location - About 1 day to fix
            fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php on lines 210..230

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 274.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ($_GET as $key => $value) {
            if ($value > 0 && substr($key,0,2) === 'id') {
                $thisUPC = substr($key,2,3);
                $data[$key][$thisUPC] = $value;
            } elseif ($value === 'LG') {
            Severity: Major
            Found in fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php and 1 other location - About 1 day to fix
            fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php on lines 1253..1273

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 274.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                public function get_view()
    {
        
        $ret = "";
            Severity: Major
            Found in fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php and 1 other location - About 1 day to fix
            fannie/modules/plugins2.0/DeliCateringOrders/noauto/DeliCateringOrdersPageBackup0627.php on lines 1444..1502

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 258.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                public function get_complete_view()
    {
        $ret = "";
        $order_num = $_GET['order_num'];
            Severity: Major
            Found in fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php and 1 other location - About 2 hrs to fix
            fannie/modules/plugins2.0/DeliCateringOrders/noauto/DeliCateringOrdersPageBackup0627.php on lines 140..170

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 130.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (!is_array($qty) && $qty > 0) {
                    //THIS I MY QUERY FOR UPC => PRICE
                    $query = $dbc->prepare("
                        SELECT 
                            name,
            Severity: Major
            Found in fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php and 1 other location - About 1 hr to fix
            fannie/modules/plugins2.0/DeliCateringOrders/noauto/DeliCateringOrdersPageBackup0627.php on lines 1389..1404

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status