CORE-POS/IS4C

View on GitHub
fannie/modules/plugins2.0/DeliCateringOrders/noauto/DeliCateringOrdersPageBackup0627.php

Summary

Maintainability
F
2 wks
Test Coverage

Method get_id_view has 898 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_id_view()
    {
        $ret = '';
        $ret .= '

    File DeliCateringOrdersPageBackup0627.php has 1326 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    COPY OF DELICATERINGORDERSPAGE.PHP
    
    <?php 
    /*******************************************************************************
    
    

      Function get_id_view has a Cognitive Complexity of 127 (exceeds 5 allowed). Consider refactoring.
      Open

          public function get_id_view()
          {
              $ret = '';
              $ret .= '
      
      

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_id_confirm_view has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
      Open

          public function get_id_confirm_view()
          {
              
              $ret = '';
              

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_id_confirm_view has 130 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function get_id_confirm_view()
          {
              
              $ret = '';
              

        Method get_review_view has 88 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function get_review_view()
            {
                $ret = "";
                $ret .= '<a class="btn btn-default" href="
                    http://localhost/IS4C/fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php">

          Method css_content has 81 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function css_content()
              {
                  return '
                          table td,th {
                              border-top: none !important;

            Method get_view has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function get_view()
                {
                    
                    $ret = "";
                    

              Function get_review_view has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function get_review_view()
                  {
                      $ret = "";
                      $ret .= '<a class="btn btn-default" href="
                          http://localhost/IS4C/fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php">

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function get_view()
                  {
                      
                      $ret = "";
                      
              fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php on lines 1357..1414

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 258.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function get_complete_view()
                  {        
                      $ret = "";
                      $order_num = $_GET['order_num'];
                      
              fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php on lines 51..79

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 130.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      foreach ($order as $upc => $qty) {
                          $query = $dbc->prepare("
                              SELECT 
                                  name, 
                                  price
              fannie/modules/plugins2.0/DeliCateringOrders/DeliCateringOrdersPage.php on lines 1294..1314

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 107.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status