Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/GiveUsMoneyPlugin/GumCheckTemplate.php

Summary

Maintainability
C
1 day
Test Coverage

Method renderAsPDF has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function renderAsPDF($pdf)
    {
        $margins = $pdf->GetMargins();
        // this was written BEFORE patching
        // fpdf to correctly return the top margin
Severity: Major
Found in fannie/modules/plugins2.0/GiveUsMoneyPlugin/GumCheckTemplate.php - About 2 hrs to fix

    Method __construct has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct($custdata, $meminfo, $amount, $memo='', $check_number=false, $date=false)
    {
        global $FANNIE_PLUGIN_SETTINGS;
        $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['GiveUsMoneyDB']);
        $settings = new GumSettingsModel($dbc);
    Severity: Major
    Found in fannie/modules/plugins2.0/GiveUsMoneyPlugin/GumCheckTemplate.php - About 2 hrs to fix

      Function __construct has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __construct($custdata, $meminfo, $amount, $memo='', $check_number=false, $date=false)
    {
        global $FANNIE_PLUGIN_SETTINGS;
        $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['GiveUsMoneyDB']);
        $settings = new GumSettingsModel($dbc);
      Severity: Minor
      Found in fannie/modules/plugins2.0/GiveUsMoneyPlugin/GumCheckTemplate.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method renderAsHTML has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function renderAsHTML()
    {
       $ret = '<div class="checkPreview" style="border: solid 1px black; 
                background-color: #ccc; padding: 3px; width: 100%;">';
      Severity: Minor
      Found in fannie/modules/plugins2.0/GiveUsMoneyPlugin/GumCheckTemplate.php - About 1 hr to fix

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct($custdata, $meminfo, $amount, $memo='', $check_number=false, $date=false)
        Severity: Minor
        Found in fannie/modules/plugins2.0/GiveUsMoneyPlugin/GumCheckTemplate.php - About 45 mins to fix

          Function renderAsPDF has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function renderAsPDF($pdf)
    {
        $margins = $pdf->GetMargins();
        // this was written BEFORE patching
        // fpdf to correctly return the top margin
          Severity: Minor
          Found in fannie/modules/plugins2.0/GiveUsMoneyPlugin/GumCheckTemplate.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status