Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/HrWeb/Employee/EmployeesPage.php

Summary

Maintainability
F
3 days
Test Coverage

Function viewOrEdit has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

    private function viewOrEdit($emp)
    {
        $canEdit = FannieAuth::validateUserQuiet('hr_editor');
        $this->connection->selectDB($this->default_db);
        $store = new StoresModel($this->connection);
Severity: Minor
Found in fannie/modules/plugins2.0/HrWeb/Employee/EmployeesPage.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method viewOrEdit has 128 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function viewOrEdit($emp)
    {
        $canEdit = FannieAuth::validateUserQuiet('hr_editor');
        $this->connection->selectDB($this->default_db);
        $store = new StoresModel($this->connection);
Severity: Major
Found in fannie/modules/plugins2.0/HrWeb/Employee/EmployeesPage.php - About 5 hrs to fix

    File EmployeesPage.php has 312 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

include(__DIR__ . '/../../../../config.php');
if (!class_exists('FannieAPI')) {
    include(__DIR__ . '/../../../../classlib2.0/FannieAPI.php');
    Severity: Minor
    Found in fannie/modules/plugins2.0/HrWeb/Employee/EmployeesPage.php - About 3 hrs to fix

      Method get_view has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function get_view()
    {
        $editCSS = FannieAuth::validateUserQuiet('hr_editor') ? '' : 'collapse';
        $this->connection->selectDB($this->default_db);
        $settings = $this->config->get('PLUGIN_SETTINGS');
      Severity: Major
      Found in fannie/modules/plugins2.0/HrWeb/Employee/EmployeesPage.php - About 2 hrs to fix

        Method post_id_handler has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function post_id_handler()
    {
        $new = !$this->id ? true : false;
        $settings = $this->config->get('PLUGIN_SETTINGS');
        $this->connection->selectDB($settings['HrWebDB']);
        Severity: Minor
        Found in fannie/modules/plugins2.0/HrWeb/Employee/EmployeesPage.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ($canEdit) {
            $ret .= '<select name="dept[]" multiple class="form-control" size="5">';
            foreach ($dept->find('departmentName') as $d) {
                $selected = $this->connection->getValue($prep, array($emp->employeeID(), $d->departmentID())) ? 'selected' : '';
                $ret .= sprintf('<option %s value="%d">%s</option>', $selected, $d->departmentID(), $d->departmentName());
          Severity: Major
          Found in fannie/modules/plugins2.0/HrWeb/Employee/EmployeesPage.php and 1 other location - About 3 hrs to fix
          fannie/modules/plugins2.0/HrWeb/Employee/EmployeesPage.php on lines 235..248

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 152.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ($canEdit) {
            $ret .= '<select name="pos[]" multiple class="form-control" size="5">';
            foreach ($pos->find('positionName') as $p) {
                $selected = $this->connection->getValue($prep, array($emp->employeeID(), $p->positionID())) ? 'selected' : '';
                $ret .= sprintf('<option %s value="%d">%s</option>', $selected, $p->positionID(), $p->positionName());
          Severity: Major
          Found in fannie/modules/plugins2.0/HrWeb/Employee/EmployeesPage.php and 1 other location - About 3 hrs to fix
          fannie/modules/plugins2.0/HrWeb/Employee/EmployeesPage.php on lines 219..232

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 152.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status