CORE-POS/IS4C

View on GitHub
fannie/modules/plugins2.0/InstaCart/InstaInExPage.php

Summary

Maintainability
D
1 day
Test Coverage

Method departmentTables has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function departmentTables()
    {
        $plugin = $this->config->get('PLUGIN_SETTINGS');
        $ret = '<div class="panel panel-default">
            <div class="panel-heading">Super Departments</div>
Severity: Major
Found in fannie/modules/plugins2.0/InstaCart/InstaInExPage.php - About 3 hrs to fix

    File InstaInExPage.php has 274 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    use COREPOS\Fannie\API\item\ItemText;
    use COREPOS\Fannie\API\lib\FannieUI;
    
    
    Severity: Minor
    Found in fannie/modules/plugins2.0/InstaCart/InstaInExPage.php - About 2 hrs to fix

      Method get_view has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function get_view()
          {
              $this->addScript('../../../src/javascript/chosen/chosen.jquery.min.js');
              $this->addCssFile('../../../src/javascript/chosen/bootstrap-chosen.css');
              $this->addOnloadCommand("\$('select.chosen:visible').chosen();\n");
      Severity: Minor
      Found in fannie/modules/plugins2.0/InstaCart/InstaInExPage.php - About 2 hrs to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            protected function post_super_handler()
            {
                $plugin = $this->config->get('PLUGIN_SETTINGS');
                $table = $plugin['InstaCartDB'] . $this->connection->sep() . 'InstaSupers';
                $prep = $this->connection->prepare("SELECT instaSuperID FROM {$table} WHERE instaSuperID=?");
        Severity: Major
        Found in fannie/modules/plugins2.0/InstaCart/InstaInExPage.php and 2 other locations - About 2 hrs to fix
        fannie/modules/plugins2.0/InstaCart/InstaInExPage.php on lines 57..68
        fannie/modules/plugins2.0/InstaCart/InstaInExPage.php on lines 80..91

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 128.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            protected function post_dept_handler()
            {
                $plugin = $this->config->get('PLUGIN_SETTINGS');
                $table = $plugin['InstaCartDB'] . $this->connection->sep() . 'InstaDepts';
                $prep = $this->connection->prepare("SELECT instaDeptID FROM {$table} WHERE instaDeptID=?");
        Severity: Major
        Found in fannie/modules/plugins2.0/InstaCart/InstaInExPage.php and 2 other locations - About 2 hrs to fix
        fannie/modules/plugins2.0/InstaCart/InstaInExPage.php on lines 34..45
        fannie/modules/plugins2.0/InstaCart/InstaInExPage.php on lines 80..91

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 128.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            protected function post_sub_handler()
            {
                $plugin = $this->config->get('PLUGIN_SETTINGS');
                $table = $plugin['InstaCartDB'] . $this->connection->sep() . 'InstaSubs';
                $prep = $this->connection->prepare("SELECT instaSubID FROM {$table} WHERE instaSubID=?");
        Severity: Major
        Found in fannie/modules/plugins2.0/InstaCart/InstaInExPage.php and 2 other locations - About 2 hrs to fix
        fannie/modules/plugins2.0/InstaCart/InstaInExPage.php on lines 34..45
        fannie/modules/plugins2.0/InstaCart/InstaInExPage.php on lines 57..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 128.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status