Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/MenuScreens/MSItems.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method getItemRow has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getItemRow($item)
    {
        $item = $item->toStdClass();
        $item->metadata = json_decode($item->metadata, true);
        $ret = <<<HTML
Severity: Major
Found in fannie/modules/plugins2.0/MenuScreens/MSItems.php - About 3 hrs to fix

    Method get_id_view has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function get_id_view()
    {
        $model = new MenuScreensModel($this->connection);
        $model->menuScreenID($this->id);
        $model->load();
    Severity: Major
    Found in fannie/modules/plugins2.0/MenuScreens/MSItems.php - About 2 hrs to fix

      Method post_id_handler has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function post_id_handler()
    {
        $itemIDs = FormLib::get('itemID', array());
        $cols = FormLib::get('col');
        $types = FormLib::get('type');
      Severity: Minor
      Found in fannie/modules/plugins2.0/MenuScreens/MSItems.php - About 1 hr to fix

        Function getItemRow has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getItemRow($item)
    {
        $item = $item->toStdClass();
        $item->metadata = json_decode($item->metadata, true);
        $ret = <<<HTML
        Severity: Minor
        Found in fannie/modules/plugins2.0/MenuScreens/MSItems.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status