CORE-POS/IS4C

View on GitHub
fannie/modules/plugins2.0/Mercato/MercatoCorrections2.php

Summary

Maintainability
D
2 days
Test Coverage

Method post_id_view has 210 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function post_id_view()
    {
        list($date, $tnum) = explode(':', $this->id);
        list($emp, $reg, $trans) = explode('-', $tnum);
        $storeID = FormLib::get('storeID');
Severity: Major
Found in fannie/modules/plugins2.0/Mercato/MercatoCorrections2.php - About 1 day to fix

    File MercatoCorrections2.php has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    include(__DIR__ . '/../../../config.php');
    if (!class_exists('FannieAPI')) {
        include(__DIR__ . '/../../../classlib2.0/FannieAPI.php');
    Severity: Minor
    Found in fannie/modules/plugins2.0/Mercato/MercatoCorrections2.php - About 2 hrs to fix

      Method get_id_view has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function get_id_view()
          {
              list($date, $tnum) = explode(':', $this->id);
              list($e, $r, $t) = explode('-', $tnum);
              $prep = $this->connection->prepare("SELECT upc, description, trans_id, store_id
      Severity: Minor
      Found in fannie/modules/plugins2.0/Mercato/MercatoCorrections2.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if ($dtax > 0) {
                    $fix1P = $this->connection->prepare("UPDATE " . FannieDB::fqn('dlog_15', 'trans') . "
                        SET regPrice=?
                        WHERE tdate BETWEEN ? AND ?
                            AND emp_no=?
        Severity: Major
        Found in fannie/modules/plugins2.0/Mercato/MercatoCorrections2.php and 1 other location - About 4 hrs to fix
        fannie/modules/plugins2.0/Mercato/MercatoCorrections2.php on lines 106..143

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 180.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if ($rtax > 0) {
                    $fix1P = $this->connection->prepare("UPDATE " . FannieDB::fqn('dlog_15', 'trans') . "
                        SET regPrice=?
                        WHERE tdate BETWEEN ? AND ?
                            AND emp_no=?
        Severity: Major
        Found in fannie/modules/plugins2.0/Mercato/MercatoCorrections2.php and 1 other location - About 4 hrs to fix
        fannie/modules/plugins2.0/Mercato/MercatoCorrections2.php on lines 145..184

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 180.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status