Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/MyWeb/MyWebSpoImport.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method addItems has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function addItems($dbc, $orderID, $items, $cardNo)
    {
        $PENDING = FannieDB::fqn('PendingSpecialOrder', 'trans');
        $tidP = $dbc->prepare("SELECT MAX(trans_id),MAX(voided),MAX(numflag) 
                FROM {$PENDING} WHERE order_id=?");
Severity: Major
Found in fannie/modules/plugins2.0/MyWeb/MyWebSpoImport.php - About 2 hrs to fix

    Method setMember has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function setMember($dbc, $orderID, $queue)
    {
        $cardNo = $queue['cardNo'];
        $person = $this->findPersonByName($dbc, $cardNo, $queue['name']);
    Severity: Minor
    Found in fannie/modules/plugins2.0/MyWeb/MyWebSpoImport.php - About 1 hr to fix

      Function addItems has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function addItems($dbc, $orderID, $items, $cardNo)
    {
        $PENDING = FannieDB::fqn('PendingSpecialOrder', 'trans');
        $tidP = $dbc->prepare("SELECT MAX(trans_id),MAX(voided),MAX(numflag) 
                FROM {$PENDING} WHERE order_id=?");
      Severity: Minor
      Found in fannie/modules/plugins2.0/MyWeb/MyWebSpoImport.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function findPersonByName has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function findPersonByName($dbc, $cardNo, $name)
    {
        $person = 1;
        $findP = $dbc->prepare('SELECT personNum FROM custdata WHERE CardNo=? AND (FirstName LIKE ? OR LastName LIKE ?)');
        foreach (explode(' ', $name) as $part) {
      Severity: Minor
      Found in fannie/modules/plugins2.0/MyWeb/MyWebSpoImport.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function run()
    {
        if ($this->isLocked()) {
            return true;
        }
      Severity: Minor
      Found in fannie/modules/plugins2.0/MyWeb/MyWebSpoImport.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status