fannie/modules/plugins2.0/OverShortTools/OverShortCashierPage.php
Method displayCashier
has 194 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function displayCashier($date,$empno,$mode)
{
global $FANNIE_PLUGIN_SETTINGS, $FANNIE_OP_DB;
$dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['OverShortDatabase']);
$store = FormLib::get('store', 1);
Function displayCashier
has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring. Open
Open
function displayCashier($date,$empno,$mode)
{
global $FANNIE_PLUGIN_SETTINGS, $FANNIE_OP_DB;
$dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['OverShortDatabase']);
$store = FormLib::get('store', 1);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File OverShortCashierPage.php
has 312 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
<?php
/*******************************************************************************
Copyright 2013 Whole Foods Co-op
Method save
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function save($empno,$date,$store,$tenders,$checks,$notes){
global $FANNIE_PLUGIN_SETTINGS;
$dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['OverShortDatabase']);
$model = new DailyNotesModel($dbc);
Method save
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
function save($empno,$date,$store,$tenders,$checks,$notes){
Function save
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
function save($empno,$date,$store,$tenders,$checks,$notes){
global $FANNIE_PLUGIN_SETTINGS;
$dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['OverShortDatabase']);
$model = new DailyNotesModel($dbc);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"