Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/OverShortTools/OverShortMAS.php

Summary

Maintainability
F
1 wk
Test Coverage

Method get_data has 524 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function get_data(){
        global $FANNIE_OP_DB;
        $dlog = DTransactionsModel::selectDlog($this->startDate, $this->endDate);
        $dtrans = DTransactionsModel::selectDtrans($this->startDate, $this->endDate);
        $mc = FormLib::get('mercato');
Severity: Major
Found in fannie/modules/plugins2.0/OverShortTools/OverShortMAS.php - About 2 days to fix

    Function get_data has a Cognitive Complexity of 99 (exceeds 5 allowed). Consider refactoring.
    Open

        function get_data(){
        global $FANNIE_OP_DB;
        $dlog = DTransactionsModel::selectDlog($this->startDate, $this->endDate);
        $dtrans = DTransactionsModel::selectDtrans($this->startDate, $this->endDate);
        $mc = FormLib::get('mercato');
    Severity: Minor
    Found in fannie/modules/plugins2.0/OverShortTools/OverShortMAS.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File OverShortMAS.php has 636 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op
    Severity: Major
    Found in fannie/modules/plugins2.0/OverShortTools/OverShortMAS.php - About 1 day to fix

      Function get_startDate_endDate_view has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          function get_startDate_endDate_view(){
        global $FANNIE_URL;
        $records = \COREPOS\Fannie\API\data\DataCache::getFile('daily');
        if ($records !== False)
            $records = unserialize($records);
      Severity: Minor
      Found in fannie/modules/plugins2.0/OverShortTools/OverShortMAS.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_startDate_endDate_view has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function get_startDate_endDate_view(){
        global $FANNIE_URL;
        $records = \COREPOS\Fannie\API\data\DataCache::getFile('daily');
        if ($records !== False)
            $records = unserialize($records);
      Severity: Minor
      Found in fannie/modules/plugins2.0/OverShortTools/OverShortMAS.php - About 1 hr to fix

        Method get_view has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function get_view(){
        global $FANNIE_URL;
        $stores  = FormLib::storePicker();
        $ret = '<form action="OverShortMAS.php" method="get">
            <div class="col-sm-4">
        Severity: Minor
        Found in fannie/modules/plugins2.0/OverShortTools/OverShortMAS.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ($w['store_id'] == '50' && $w['salesCode'] == '41205') {
                $amts = array(
                    1 => 0,
                    2 => 0,
                    '??' => 0,
          Severity: Major
          Found in fannie/modules/plugins2.0/OverShortTools/OverShortMAS.php and 1 other location - About 2 days to fix
          fannie/modules/plugins2.0/OverShortTools/OverShortMAS.php on lines 341..403

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 548.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ($w['store_id'] == '50' && $w['salesCode'] == '41600') {
                $amts = array(
                    1 => 0,
                    2 => 0,
                    '??' => 0,
          Severity: Major
          Found in fannie/modules/plugins2.0/OverShortTools/OverShortMAS.php and 1 other location - About 2 days to fix
          fannie/modules/plugins2.0/OverShortTools/OverShortMAS.php on lines 278..340

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 548.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status