Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/PIKiller/AccessSignupPage.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method get_view has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function get_view()
    {

        return <<<HTML
<form method="post" action="AccessSignupPage.php">
Severity: Major
Found in fannie/modules/plugins2.0/PIKiller/AccessSignupPage.php - About 2 hrs to fix

    Method get_id_handler has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function get_id_handler()
    {
        $prep = $this->connection->prepare("SELECT memType, FirstName, LastName
            FROM custdata
            WHERE CardNo=? AND personNum=1");
    Severity: Minor
    Found in fannie/modules/plugins2.0/PIKiller/AccessSignupPage.php - About 1 hr to fix

      Method post_id_handler has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function post_id_handler()
    {
        $numflag = FormLib::get('program');
        $tNo = DTrans::getTransNo($this->connection);
        DTrans::addItem($this->connection, $tNo, array(
      Severity: Minor
      Found in fannie/modules/plugins2.0/PIKiller/AccessSignupPage.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in fannie/modules/plugins2.0/PIKiller/AccessSignupPage.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return false;
          Severity: Major
          Found in fannie/modules/plugins2.0/PIKiller/AccessSignupPage.php - About 30 mins to fix

            Function get_id_handler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function get_id_handler()
    {
        $prep = $this->connection->prepare("SELECT memType, FirstName, LastName
            FROM custdata
            WHERE CardNo=? AND personNum=1");
            Severity: Minor
            Found in fannie/modules/plugins2.0/PIKiller/AccessSignupPage.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status