Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/PIKiller/PISearchPage.php

Summary

Maintainability
C
1 day
Test Coverage

Method get_id_first_last_handler has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_id_first_last_handler()
    {
        if (empty($this->id) && empty($this->last) && empty($this->first)) {
            return true; // invalid search  
        }
Severity: Minor
Found in fannie/modules/plugins2.0/PIKiller/PISearchPage.php - About 1 hr to fix

    Function get_id_first_last_view has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        function get_id_first_last_view()
    {
        if (count($this->results) == 0) {
            return '<tr><td colspan="9"><p>No results from search</p></td></tr>'
                .$this->get_view();
    Severity: Minor
    Found in fannie/modules/plugins2.0/PIKiller/PISearchPage.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_id_first_last_handler has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function get_id_first_last_handler()
    {
        if (empty($this->id) && empty($this->last) && empty($this->first)) {
            return true; // invalid search  
        }
    Severity: Minor
    Found in fannie/modules/plugins2.0/PIKiller/PISearchPage.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_id_first_last_view has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function get_id_first_last_view()
    {
        if (count($this->results) == 0) {
            return '<tr><td colspan="9"><p>No results from search</p></td></tr>'
                .$this->get_view();
    Severity: Minor
    Found in fannie/modules/plugins2.0/PIKiller/PISearchPage.php - About 1 hr to fix

      Method get_view has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function get_view()
    {
        global $FANNIE_URL;
        ob_start();
        ?>
      Severity: Minor
      Found in fannie/modules/plugins2.0/PIKiller/PISearchPage.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                        return false;
        Severity: Major
        Found in fannie/modules/plugins2.0/PIKiller/PISearchPage.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return true;
          Severity: Major
          Found in fannie/modules/plugins2.0/PIKiller/PISearchPage.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status