Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php

Summary

Maintainability
F
3 days
Test Coverage

Method post_id_handler has 164 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function post_id_handler()
    {
        global $FANNIE_OP_DB;
        if (!FannieAuth::validateUserQuiet('editmembers') && !FannieAuth::validateUserQuiet('editmembers_csc'))
            return $this->unknown_request_handler();
Severity: Major
Found in fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php - About 6 hrs to fix

    Function post_id_handler has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
    Open

        function post_id_handler()
    {
        global $FANNIE_OP_DB;
        if (!FannieAuth::validateUserQuiet('editmembers') && !FannieAuth::validateUserQuiet('editmembers_csc'))
            return $this->unknown_request_handler();
    Severity: Minor
    Found in fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File PISuspensionPage.php has 364 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php 
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op
    Severity: Minor
    Found in fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php - About 4 hrs to fix

      Method get_id_setpaperwork_handler has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function get_id_setpaperwork_handler()
    {
        global $FANNIE_OP_DB;
        if (!FannieAuth::validateUserQuiet('editmembers') && !FannieAuth::validateUserQuiet('editmembers_csc'))
            return $this->unknown_request_handler();
      Severity: Major
      Found in fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php - About 2 hrs to fix

        Function get_id_view has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function get_id_view(){
        global $FANNIE_URL;
        ob_start();
        echo '<tr><td>';
        foreach($this->__models['history'] as $obj){
        Severity: Minor
        Found in fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_id_edit_view has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function get_id_edit_view(){
        ob_start();
        echo '<tr><td>';
        echo '<form action="PISuspensionPage.php" method="post">';
        echo '<input type="hidden" name="id" value="'.$this->id.'" />';
        Severity: Minor
        Found in fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php - About 1 hr to fix

          Function get_id_setpaperwork_handler has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function get_id_setpaperwork_handler()
    {
        global $FANNIE_OP_DB;
        if (!FannieAuth::validateUserQuiet('editmembers') && !FannieAuth::validateUserQuiet('editmembers_csc'))
            return $this->unknown_request_handler();
          Severity: Minor
          Found in fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function get_id_edit_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              function get_id_edit_view(){
        ob_start();
        echo '<tr><td>';
        echo '<form action="PISuspensionPage.php" method="post">';
        echo '<input type="hidden" name="id" value="'.$this->id.'" />';
          Severity: Minor
          Found in fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              protected function get_id_handler(){
        global $FANNIE_OP_DB;
        $this->card_no = $this->id;

        $this->title = 'Suspension History : Member '.$this->card_no;
          Severity: Major
          Found in fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php and 2 other locations - About 1 hr to fix
          fannie/modules/plugins2.0/PIKiller/PIEquityPage.php on lines 34..45
          fannie/modules/plugins2.0/PIKiller/PINoteHistoryPage.php on lines 34..45

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              protected function get_id_fixpaperwork_handler(){
        global $FANNIE_OP_DB;
        $susp = new SuspensionsModel(FannieDB::get($FANNIE_OP_DB));
        $susp->cardno($this->id);
        if (!$susp->load()){
          Severity: Major
          Found in fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php and 1 other location - About 1 hr to fix
          fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php on lines 85..100

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              protected function get_id_fixaddress_handler(){
        global $FANNIE_OP_DB;
        $susp = new SuspensionsModel(FannieDB::get($FANNIE_OP_DB));
        $susp->cardno($this->id);
        if (!$susp->load()){
          Severity: Major
          Found in fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php and 1 other location - About 1 hr to fix
          fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php on lines 102..117

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      foreach($current as $obj) {
                if ($obj->reasonCode() != $code || $obj->suspensionTypeID() != $m_status) {
                    $changed = true;
                }
                $cas_model->savedType($obj->savedType());
          Severity: Major
          Found in fannie/modules/plugins2.0/PIKiller/PISuspensionPage.php and 2 other locations - About 1 hr to fix
          fannie/mem/MemStatusEditor.php on lines 177..189
          fannie/mem/StatusFromSearch.php on lines 132..144

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status