Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php

Summary

Maintainability
F
1 wk
Test Coverage

Method post_handler has 202 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function post_handler()
    {
        try {
            $pDate = $this->form->date;
            $invoice = $this->form->invoice;
Severity: Major
Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php - About 1 day to fix

    File PaycardFixReturn.php has 383 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

include(__DIR__ . '/../../../config.php');
if (!class_exists('FannieAPI')) {
    include(__DIR__ . '/../../../classlib2.0/FannieAPI.php');
    Severity: Minor
    Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php - About 5 hrs to fix

      Method get_id_view has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function get_id_view()
    {
        try {
            $pDate = trim($this->form->date);
            $transNum = trim($this->form->correctTrans);
      Severity: Major
      Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php - About 2 hrs to fix

        Function post_handler has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function post_handler()
    {
        try {
            $pDate = $this->form->date;
            $invoice = $this->form->invoice;
        Severity: Minor
        Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_view has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function get_view()
    {
        return <<<HTML
<p class="well">
This will try to run a refund transaction via Mercury.
        Severity: Minor
        Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php - About 1 hr to fix

          Function get_id_view has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function get_id_view()
    {
        try {
            $pDate = trim($this->form->date);
            $transNum = trim($this->form->correctTrans);
          Severity: Minor
          Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return <<<HTML
<p>
Refunding \${$returnAmount} to card {$ptrans['PAN']} using {$using}.
</p>
<form method="post" action="PaycardFixReturn.php">
          Severity: Major
          Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return '<div class="alert alert-danger">Correction transaction not found</div>'
                    . $this->get_view();
            Severity: Major
            Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return sprintf('<div class="alert alert-danger">Correction transaction amount (%.2f) does not
                    match charge refund amount (%.2f)</div>', -1*$cRow['total'], $returnAmount)
                    . $this->get_view();
              Severity: Major
              Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php - About 30 mins to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        if (strlen($respXML) > 0 && $resp !== false) {
            $elapsed = microtime(true) - $startTime;
            $pcRow[] = date('Y-m-d H:i:s');
            $pcRow[] = $elapsed;
            $pcRow[] = 0;
                Severity: Major
                Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php and 2 other locations - About 3 days to fix
                fannie/modules/plugins2.0/PaycardFix/PaycardFixSale.php on lines 200..246
                fannie/modules/plugins2.0/PaycardFix/PaycardFixVoid.php on lines 190..236

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 584.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ($transNum) {
            $dlog = $this->config->get('TRANS_DB') . $this->connection->sep() . 'dlog';
            $correctP = $this->connection->prepare("
                SELECT *
                FROM {$dlog}
                Severity: Major
                Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php and 1 other location - About 4 hrs to fix
                fannie/modules/plugins2.0/PaycardFix/PaycardFixSale.php on lines 355..377

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 163.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 4 locations. Consider refactoring.
                Open

                    private function refnum($emp, $reg, $trans, $id)
    {
        $ref = "";
        $ref .= date("md");
        $ref .= str_pad($emp, 4, "0", STR_PAD_LEFT);
                Severity: Major
                Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php and 3 other locations - About 3 hrs to fix
                fannie/modules/plugins2.0/PaycardFix/PaycardFixSale.php on lines 57..66
                fannie/modules/plugins2.0/PaycardFix/PaycardFixVoid.php on lines 42..51
                fannie/modules/plugins2.0/RecurringEquity/EqRecurTask.php on lines 314..323

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 148.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                    protected function get_resultID_view()
    {
        $table = $this->config->get('TRANS_DB') . $this->connection->sep() . 'PaycardTransactions';
        $prep = $this->connection->prepare("SELECT * FROM {$table} WHERE storeRowID=? and dateID=?");
        $row = $this->connection->getRow($prep, array($this->resultID, date('Ymd')));
                Severity: Major
                Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php and 2 other locations - About 2 hrs to fix
                fannie/modules/plugins2.0/PaycardFix/PaycardFixSale.php on lines 68..82
                fannie/modules/plugins2.0/PaycardFix/PaycardFixVoid.php on lines 53..67

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 137.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        $pcRow = array(
            date('Ymd'),
            $EMP,
            $REG,
            $TRANS,
                Severity: Minor
                Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php and 1 other location - About 50 mins to fix
                fannie/modules/plugins2.0/PaycardFix/PaycardFixSale.php on lines 127..145

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 97.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status