Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/PaycardFix/PaycardFixVoid.php

Summary

Maintainability
F
5 days
Test Coverage

Method post_handler has 155 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function post_handler()
    {
        try {
            $pDate = $this->form->date;
            $invoice = $this->form->invoice;
Severity: Major
Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixVoid.php - About 6 hrs to fix

    File PaycardFixVoid.php has 276 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

include(__DIR__ . '/../../../config.php');
if (!class_exists('FannieAPI')) {
    include(__DIR__ . '/../../../classlib2.0/FannieAPI.php');
    Severity: Minor
    Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixVoid.php - About 2 hrs to fix

      Function post_handler has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function post_handler()
    {
        try {
            $pDate = $this->form->date;
            $invoice = $this->form->invoice;
      Severity: Minor
      Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixVoid.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_id_view has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function get_id_view()
    {
        try {
            $pDate = trim($this->form->date);
        } catch (Exception $ex) {
      Severity: Minor
      Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixVoid.php - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                if (strlen($respXML) > 0 && $resp !== false) {
            $elapsed = microtime(true) - $startTime;
            $pcRow[] = date('Y-m-d H:i:s');
            $pcRow[] = $elapsed;
            $pcRow[] = 0;
        Severity: Major
        Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixVoid.php and 2 other locations - About 3 days to fix
        fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php on lines 200..246
        fannie/modules/plugins2.0/PaycardFix/PaycardFixSale.php on lines 200..246

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 584.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

            private function refnum($emp, $reg, $trans, $id)
    {
        $ref = "";
        $ref .= date("md");
        $ref .= str_pad($emp, 4, "0", STR_PAD_LEFT);
        Severity: Major
        Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixVoid.php and 3 other locations - About 3 hrs to fix
        fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php on lines 57..66
        fannie/modules/plugins2.0/PaycardFix/PaycardFixSale.php on lines 57..66
        fannie/modules/plugins2.0/RecurringEquity/EqRecurTask.php on lines 314..323

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 148.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

            protected function get_resultID_view()
    {
        $table = $this->config->get('TRANS_DB') . $this->connection->sep() . 'PaycardTransactions';
        $prep = $this->connection->prepare("SELECT * FROM {$table} WHERE storeRowID=? and dateID=?");
        $row = $this->connection->getRow($prep, array($this->resultID, date('Ymd')));
        Severity: Major
        Found in fannie/modules/plugins2.0/PaycardFix/PaycardFixVoid.php and 2 other locations - About 2 hrs to fix
        fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php on lines 68..82
        fannie/modules/plugins2.0/PaycardFix/PaycardFixSale.php on lines 68..82

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 137.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status