Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/RP/RpSegmentation.php

Summary

Maintainability
D
2 days
Test Coverage

Method post_segID_store_handler has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function post_segID_store_handler()
    {
        $json = array('err' => false, 'msg' => '');

        $days = FormLib::get('day', array());
Severity: Major
Found in fannie/modules/plugins2.0/RP/RpSegmentation.php - About 2 hrs to fix

    File RpSegmentation.php has 272 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

include(__DIR__ . '/../../../config.php');
if (!class_exists('FannieAPI')) {
    include(__DIR__ . '/../../../classlib2.0/FannieAPI.php');
    Severity: Minor
    Found in fannie/modules/plugins2.0/RP/RpSegmentation.php - About 2 hrs to fix

      Method get_view has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function get_view()
    {
        $backLink = isset($_SERVER['HTTP_REFERER']) && strpos($_SERVER['HTTP_REFERER'], 'RpDirectPage.php')
            ? 'RpDirectPage.php'
            : 'RpOrderPage.php';
      Severity: Major
      Found in fannie/modules/plugins2.0/RP/RpSegmentation.php - About 2 hrs to fix

        Method get_segID_store_handler has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function get_segID_store_handler()
    {
        $ts = strtotime($this->segID);
        if ($ts === false || date('N', $ts) != 1) {
            echo '<div class="alert alert-danger">Not a valid week</div>';
        Severity: Minor
        Found in fannie/modules/plugins2.0/RP/RpSegmentation.php - About 1 hr to fix

          Method javascriptContent has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function javascriptContent()
    {
        return <<<JAVASCRIPT
function getPlan(start, store) {
    var dstr = 'segID=' + start + '&store=' + store;
          Severity: Minor
          Found in fannie/modules/plugins2.0/RP/RpSegmentation.php - About 1 hr to fix

            Function post_segID_store_handler has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function post_segID_store_handler()
    {
        $json = array('err' => false, 'msg' => '');

        $days = FormLib::get('day', array());
            Severity: Minor
            Found in fannie/modules/plugins2.0/RP/RpSegmentation.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get_view has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function get_view()
    {
        $backLink = isset($_SERVER['HTTP_REFERER']) && strpos($_SERVER['HTTP_REFERER'], 'RpDirectPage.php')
            ? 'RpDirectPage.php'
            : 'RpOrderPage.php';
            Severity: Minor
            Found in fannie/modules/plugins2.0/RP/RpSegmentation.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ($rows as $row) {
            switch ($row['DoW']) {
                case 1:
                    $lastYear['Sun'] = round($row['ttl'], 2);
                    break;
            Severity: Major
            Found in fannie/modules/plugins2.0/RP/RpSegmentation.php and 1 other location - About 7 hrs to fix
            fannie/modules/plugins2.0/RP/RpCleanupTask.php on lines 51..75

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 224.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status