Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/RecurringEquity/EqRecurTask.php

Summary

Maintainability
D
2 days
Test Coverage

Method run has 153 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        $this->CREDENTIALS = json_decode(file_get_contents(__DIR__ . '/credentials.json'), true);
        $dbc = FannieDB::get(FannieConfig::config('TRANS_DB'));
        $payments = $this->getTransactions($dbc);
Severity: Major
Found in fannie/modules/plugins2.0/RecurringEquity/EqRecurTask.php - About 6 hrs to fix

    File EqRecurTask.php has 312 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
  Process recurring transactions
    Severity: Minor
    Found in fannie/modules/plugins2.0/RecurringEquity/EqRecurTask.php - About 3 hrs to fix

      Function run has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          public function run()
    {
        $this->CREDENTIALS = json_decode(file_get_contents(__DIR__ . '/credentials.json'), true);
        $dbc = FannieDB::get(FannieConfig::config('TRANS_DB'));
        $payments = $this->getTransactions($dbc);
      Severity: Minor
      Found in fannie/modules/plugins2.0/RecurringEquity/EqRecurTask.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method successTransaction has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function successTransaction($dbc, $emp, $reg, $trans, $amt, $card_no, $pcID)
    {
        $dtrans = DTrans::defaults();
        $dtrans['emp_no'] = $emp;
        $dtrans['register_no'] = $reg;
      Severity: Minor
      Found in fannie/modules/plugins2.0/RecurringEquity/EqRecurTask.php - About 1 hr to fix

        Method getTransactions has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getTransactions($dbc)
    {
        global $argv;
        $dateID = date('Ymd', strtotime('31 days ago'));
        if (isset($argv) && is_array($argv)) {
        Severity: Minor
        Found in fannie/modules/plugins2.0/RecurringEquity/EqRecurTask.php - About 1 hr to fix

          Method successTransaction has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private function successTransaction($dbc, $emp, $reg, $trans, $amt, $card_no, $pcID)
          Severity: Major
          Found in fannie/modules/plugins2.0/RecurringEquity/EqRecurTask.php - About 50 mins to fix

            Function getTransactions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getTransactions($dbc)
    {
        global $argv;
        $dateID = date('Ymd', strtotime('31 days ago'));
        if (isset($argv) && is_array($argv)) {
            Severity: Minor
            Found in fannie/modules/plugins2.0/RecurringEquity/EqRecurTask.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method failTransaction has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                private function failTransaction($dbc, $emp, $reg, $trans, $card_no, $pcID)
            Severity: Minor
            Found in fannie/modules/plugins2.0/RecurringEquity/EqRecurTask.php - About 45 mins to fix

              Identical blocks of code found in 4 locations. Consider refactoring.
              Open

                  private function refnum($emp, $reg, $trans, $id)
    {
        $ref = "";
        $ref .= date("md");
        $ref .= str_pad($emp, 4, "0", STR_PAD_LEFT);
              Severity: Major
              Found in fannie/modules/plugins2.0/RecurringEquity/EqRecurTask.php and 3 other locations - About 3 hrs to fix
              fannie/modules/plugins2.0/PaycardFix/PaycardFixReturn.php on lines 57..66
              fannie/modules/plugins2.0/PaycardFix/PaycardFixSale.php on lines 57..66
              fannie/modules/plugins2.0/PaycardFix/PaycardFixVoid.php on lines 42..51

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 148.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status