Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/ShelfAudit/SaFullPage.php

Summary

Maintainability
C
1 day
Test Coverage

Method post_id_handler has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function post_id_handler()
    {
        $section = FormLib::get('section');
        $store = COREPOS\Fannie\API\lib\Store::getIdByIp();
        $super = FormLib::get('super');
Severity: Major
Found in fannie/modules/plugins2.0/ShelfAudit/SaFullPage.php - About 3 hrs to fix

    Method get_view has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function get_view()
    {
        $super = FormLib::get('super', -999);
        $section = FormLib::get('section', 0);
        $backstock = !$section ? 'checked' : 0;
    Severity: Minor
    Found in fannie/modules/plugins2.0/ShelfAudit/SaFullPage.php - About 1 hr to fix

      Method post_id_qty_handler has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function post_id_qty_handler()
    {
        $section = FormLib::get('section');
        $realQty = FormLib::get('real');
        $dbc = $this->connection;
      Severity: Minor
      Found in fannie/modules/plugins2.0/ShelfAudit/SaFullPage.php - About 1 hr to fix

        Function post_id_handler has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function post_id_handler()
    {
        $section = FormLib::get('section');
        $store = COREPOS\Fannie\API\lib\Store::getIdByIp();
        $super = FormLib::get('super');
        Severity: Minor
        Found in fannie/modules/plugins2.0/ShelfAudit/SaFullPage.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getRecent has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getRecent($dbc, $section, $super)
    {
        $store = COREPOS\Fannie\API\lib\Store::getIdByIp();
        $query = "SELECT p.upc, p.description,
                s.quantity, s.datetime,
        Severity: Minor
        Found in fannie/modules/plugins2.0/ShelfAudit/SaFullPage.php - About 1 hr to fix

          Function post_id_qty_handler has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function post_id_qty_handler()
    {
        $section = FormLib::get('section');
        $realQty = FormLib::get('real');
        $dbc = $this->connection;
          Severity: Minor
          Found in fannie/modules/plugins2.0/ShelfAudit/SaFullPage.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status