Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/ShelfAudit/SaHandheldPage.php

Summary

Maintainability
D
2 days
Test Coverage

Function get_id_handler has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    protected function get_id_handler()
    {
        $ret = array();
        $settings = $this->config->get('PLUGIN_SETTINGS');
        if ($this->id !== '') {
Severity: Minor
Found in fannie/modules/plugins2.0/ShelfAudit/SaHandheldPage.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File SaHandheldPage.php has 339 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op
Severity: Minor
Found in fannie/modules/plugins2.0/ShelfAudit/SaHandheldPage.php - About 4 hrs to fix

    Method get_id_handler has 86 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function get_id_handler()
    {
        $ret = array();
        $settings = $this->config->get('PLUGIN_SETTINGS');
        if ($this->id !== '') {
    Severity: Major
    Found in fannie/modules/plugins2.0/ShelfAudit/SaHandheldPage.php - About 3 hrs to fix

      Method javascript_content has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function javascript_content()
    {
        ob_start();
        ?>
function doubleBeep() {
      Severity: Major
      Found in fannie/modules/plugins2.0/ShelfAudit/SaHandheldPage.php - About 2 hrs to fix

        Method qtyForm has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function qtyForm($data)
    {
        $used = array(1=>true);
        $cases = '';
        foreach($data['case_sizes'] as $s){
        Severity: Minor
        Found in fannie/modules/plugins2.0/ShelfAudit/SaHandheldPage.php - About 1 hr to fix

          Method post_id_handler has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function post_id_handler()
    {
        $ret = array();
        $settings = $this->config->get('PLUGIN_SETTINGS');
        $upc = BarcodeLib::padUPC($this->id);
          Severity: Minor
          Found in fannie/modules/plugins2.0/ShelfAudit/SaHandheldPage.php - About 1 hr to fix

            Function post_id_handler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function post_id_handler()
    {
        $ret = array();
        $settings = $this->config->get('PLUGIN_SETTINGS');
        $upc = BarcodeLib::padUPC($this->id);
            Severity: Minor
            Found in fannie/modules/plugins2.0/ShelfAudit/SaHandheldPage.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function qtyForm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function qtyForm($data)
    {
        $used = array(1=>true);
        $cases = '';
        foreach($data['case_sizes'] as $s){
            Severity: Minor
            Found in fannie/modules/plugins2.0/ShelfAudit/SaHandheldPage.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status