Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/ShelfAudit/SaInvComparePage.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method post_view has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function post_view()
    {
        $upcs = FormLib::get('upc');
        $qtys = FormLib::get('qty');
        $skip = FormLib::get('exclude');
Severity: Minor
Found in fannie/modules/plugins2.0/ShelfAudit/SaInvComparePage.php - About 1 hr to fix

    Function post_view has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function post_view()
    {
        $upcs = FormLib::get('upc');
        $qtys = FormLib::get('qty');
        $skip = FormLib::get('exclude');
    Severity: Minor
    Found in fannie/modules/plugins2.0/ShelfAudit/SaInvComparePage.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_id_view has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function get_id_view()
    {
        $matches = preg_match_all("/[0-9]+/", FormLib::get('dept'), $depts);
        if ($matches == 0) {
            $depts = array();
    Severity: Minor
    Found in fannie/modules/plugins2.0/ShelfAudit/SaInvComparePage.php - About 1 hr to fix

      Method get_view has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function get_view()
    {
        $store = FormLib::storePicker();
        $vendor = new VendorsModel($this->connection);
        $vOpts = $vendor->toOptions();
      Severity: Minor
      Found in fannie/modules/plugins2.0/ShelfAudit/SaInvComparePage.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status