Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php

Summary

Maintainability
F
1 wk
Test Coverage

File SaReportPage.php has 582 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op
    Based on example code from Wedge Community Co-op
Severity: Major
Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php - About 1 day to fix

    Function csv_content has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
    Open

        function csv_content(){
        $ret = "UPC,Description,Vendor,Account#,Dept#,\"Dept Name\",Qty,Cost,Unit Cost Total,Normal Retail,Status,Normal Retail Total,Location\r\n";
        $totals = array();
        $vendors = array();
        $manuals = array();
    Severity: Minor
    Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method body_content has 153 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function body_content(){
        ob_start();
        $stores = FormLib::storePicker();
        $model = new SuperDeptNamesModel($this->connection);
        $model->whichDB($this->config->get('OP_DB'));
    Severity: Major
    Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php - About 6 hrs to fix

      Method csv_content has 139 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function csv_content(){
        $ret = "UPC,Description,Vendor,Account#,Dept#,\"Dept Name\",Qty,Cost,Unit Cost Total,Normal Retail,Status,Normal Retail Total,Location\r\n";
        $totals = array();
        $vendors = array();
        $manuals = array();
      Severity: Major
      Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php - About 5 hrs to fix

        Method getScanData has 132 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getScanData()
    {
        global $FANNIE_PLUGIN_SETTINGS,$FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['ShelfAuditDB']);
        $order='dept_no,s.section,s.datetime';
        Severity: Major
        Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php - About 5 hrs to fix

          Function getScanData has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getScanData()
    {
        global $FANNIE_PLUGIN_SETTINGS,$FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['ShelfAuditDB']);
        $order='dept_no,s.section,s.datetime';
          Severity: Minor
          Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method css_content has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function css_content(){
        ob_start();
        ?>
#bdiv {
    width: 768px;
          Severity: Major
          Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php - About 2 hrs to fix

            Method preprocess has 50 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function preprocess(){
        global $FANNIE_PLUGIN_SETTINGS,$FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['ShelfAuditDB']);
        if (!is_object($dbc) || $dbc->connections[$FANNIE_PLUGIN_SETTINGS['ShelfAuditDB']] === False){
            $this->status = 'bad - cannot connect';
            Severity: Minor
            Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php - About 2 hrs to fix

              Function preprocess has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  function preprocess(){
        global $FANNIE_PLUGIN_SETTINGS,$FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['ShelfAuditDB']);
        if (!is_object($dbc) || $dbc->connections[$FANNIE_PLUGIN_SETTINGS['ShelfAuditDB']] === False){
            $this->status = 'bad - cannot connect';
              Severity: Minor
              Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function estMargin has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function estMargin($scans, $code)
    {
        $retail = 0;
        $cost = 0;
        $match = 0;
              Severity: Minor
              Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function body_content has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  function body_content(){
        ob_start();
        $stores = FormLib::storePicker();
        $model = new SuperDeptNamesModel($this->connection);
        $model->whichDB($this->config->get('OP_DB'));
              Severity: Minor
              Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                              } elseif (strpos($row['description'], ' @ COST')) {
                    if (!isset($manuals[$row['salesCode']])) {
                        $manuals[$row['salesCode']] = array('qty'=>0.0,'ttl'=>0.0,'normalTtl'=>0.0,'costTtl'=>0.0);
                    }
                    $manuals[$row['salesCode']]['qty'] += $row['quantity'];
              Severity: Major
              Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php and 2 other locations - About 5 hrs to fix
              fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php on lines 371..380
              fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php on lines 380..389

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 197.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                              } elseif (strpos($row['description'], ' RECV ')) {
                    if (!isset($adjustUp[$row['salesCode']])) {
                        $adjustUp[$row['salesCode']] = array('qty'=>0.0,'ttl'=>0.0,'normalTtl'=>0.0,'costTtl'=>0.0);
                    }
                    $adjustUp[$row['salesCode']]['qty'] += $row['quantity'];
              Severity: Major
              Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php and 2 other locations - About 5 hrs to fix
              fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php on lines 362..371
              fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php on lines 371..380

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 197.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                              } elseif (strpos($row['description'], 'ADJ SALES')) {
                    if (!isset($adjustDown[$row['salesCode']])) {
                        $adjustDown[$row['salesCode']] = array('qty'=>0.0,'ttl'=>0.0,'normalTtl'=>0.0,'costTtl'=>0.0);
                    }
                    $adjustDown[$row['salesCode']]['qty'] += $row['quantity'];
              Severity: Major
              Found in fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php and 2 other locations - About 5 hrs to fix
              fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php on lines 362..371
              fannie/modules/plugins2.0/ShelfAudit/SaReportPage.php on lines 380..389

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 197.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status