Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/TimesheetPlugin/admin/TsEmployeesEditor.php

Summary

Maintainability
C
1 day
Test Coverage

Method get_id_view has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_id_view()
    {
        $dbc = $this->connection;
        $settings = $this->config->get('PLUGIN_SETTINGS');
        $dbc->selectDB($settings['TimesheetDatabase']);
Severity: Major
Found in fannie/modules/plugins2.0/TimesheetPlugin/admin/TsEmployeesEditor.php - About 3 hrs to fix

    Method get_view has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_view()
    {
        $dbc = $this->connection;
        $settings = $this->config->get('PLUGIN_SETTINGS');
        $dbc->selectDB($settings['TimesheetDatabase']);
    Severity: Major
    Found in fannie/modules/plugins2.0/TimesheetPlugin/admin/TsEmployeesEditor.php - About 2 hrs to fix

      File TsEmployeesEditor.php has 254 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
include(dirname(__FILE__).'/../../../../config.php');
if (!class_exists('FannieAPI')) {
    include_once(__DIR__ . '/../../../../classlib2.0/FannieAPI.php');
}
      Severity: Minor
      Found in fannie/modules/plugins2.0/TimesheetPlugin/admin/TsEmployeesEditor.php - About 2 hrs to fix

        Method post_newID_handler has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function post_newID_handler()
    {
        $dbc = $this->connection;
        $settings = $this->config->get('PLUGIN_SETTINGS');
        $dbc->selectDB($settings['TimesheetDatabase']);
        Severity: Minor
        Found in fannie/modules/plugins2.0/TimesheetPlugin/admin/TsEmployeesEditor.php - About 1 hr to fix

          Method helpContent has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function helpContent()
    {
        return <<<HTML
<p>
Timesheet employees have the following required attributes:
          Severity: Minor
          Found in fannie/modules/plugins2.0/TimesheetPlugin/admin/TsEmployeesEditor.php - About 1 hr to fix

            Function post_newID_handler has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function post_newID_handler()
    {
        $dbc = $this->connection;
        $settings = $this->config->get('PLUGIN_SETTINGS');
        $dbc->selectDB($settings['TimesheetDatabase']);
            Severity: Minor
            Found in fannie/modules/plugins2.0/TimesheetPlugin/admin/TsEmployeesEditor.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status