Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/ordering/OrderViewPage.php

Summary

Maintainability
F
1 wk
Test Coverage
F
58%

File OrderViewPage.php has 1265 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2010 Whole Foods Co-op
Severity: Major
Found in fannie/ordering/OrderViewPage.php - About 3 days to fix

    Method get_orderID_customer_handler has 347 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function get_orderID_customer_handler()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $TRANS = $this->config->get('TRANS_DB') . $dbc->sep();
    Severity: Major
    Found in fannie/ordering/OrderViewPage.php - About 1 day to fix

      Function get_orderID_customer_handler has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function get_orderID_customer_handler()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $TRANS = $this->config->get('TRANS_DB') . $dbc->sep();
      Severity: Minor
      Found in fannie/ordering/OrderViewPage.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function editableItemList has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
      Open

          private function editableItemList($orderID)
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $TRANS = $this->config->get('TRANS_DB') . $dbc->sep();
      Severity: Minor
      Found in fannie/ordering/OrderViewPage.php - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method editableItemList has 138 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function editableItemList($orderID)
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $TRANS = $this->config->get('TRANS_DB') . $dbc->sep();
      Severity: Major
      Found in fannie/ordering/OrderViewPage.php - About 5 hrs to fix

        Method get_orderID_view has 94 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function get_orderID_view()
    {
        $orderID = (int)$this->orderID;
        if ($orderID === 0) {
            return '<div class="alert alert-danger">Invalid order. <a href="OrderViewPage.php">Create new order</a>?</div>';
        Severity: Major
        Found in fannie/ordering/OrderViewPage.php - About 3 hrs to fix

          OrderViewPage has 29 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class OrderViewPage extends FannieRESTfulPage
{
    protected $header = 'View Order';
    protected $title = 'View Order';
    protected $must_authenticate = true;
          Severity: Minor
          Found in fannie/ordering/OrderViewPage.php - About 3 hrs to fix

            Function get_orderID_view has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function get_orderID_view()
    {
        $orderID = (int)$this->orderID;
        if ($orderID === 0) {
            return '<div class="alert alert-danger">Invalid order. <a href="OrderViewPage.php">Create new order</a>?</div>';
            Severity: Minor
            Found in fannie/ordering/OrderViewPage.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method itemList has 56 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function itemList($orderID,$table="PendingSpecialOrder")
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $TRANS = $this->config->get('TRANS_DB') . $dbc->sep();
            Severity: Major
            Found in fannie/ordering/OrderViewPage.php - About 2 hrs to fix

              Method getDeptForm has 52 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function getDeptForm($orderID,$transID,$description)
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $TRANS = $this->config->get('TRANS_DB') . $dbc->sep();
              Severity: Major
              Found in fannie/ordering/OrderViewPage.php - About 2 hrs to fix

                Method post_orderID_description_srp_actual_qty_dept_unitPrice_vendor_transID_changed_handler has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function post_orderID_description_srp_actual_qty_dept_unitPrice_vendor_transID_changed_handler()
    {
        $dbc = $this->connection;
        $transDB = $this->config->get('TRANS_DB') . $dbc->sep();
        $dbc->selectDB($this->config->get('TRANS_DB'));
                Severity: Minor
                Found in fannie/ordering/OrderViewPage.php - About 1 hr to fix

                  Method addUPC has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private function addUPC($orderID, $memNum, $upc, $num_cases=1)
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $TRANS = $this->config->get('TRANS_DB') . $dbc->sep();
                  Severity: Minor
                  Found in fannie/ordering/OrderViewPage.php - About 1 hr to fix

                    Method get_orderID_items_handler has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function get_orderID_items_handler()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
                    Severity: Minor
                    Found in fannie/ordering/OrderViewPage.php - About 1 hr to fix

                      Method post_orderID_transID_dept_handler has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function post_orderID_transID_dept_handler()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('TRANS_DB'));
        $upP = $dbc->prepare('
                      Severity: Minor
                      Found in fannie/ordering/OrderViewPage.php - About 1 hr to fix

                        Method reprice has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            private function reprice($oid,$tid,$reg=false)
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $TRANS = $this->config->get('TRANS_DB') . $dbc->sep();
                        Severity: Minor
                        Found in fannie/ordering/OrderViewPage.php - About 1 hr to fix

                          Method post_orderID_noteDept_noteText_ph1_ph2_email_handler has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              protected function post_orderID_noteDept_noteText_ph1_ph2_email_handler()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('TRANS_DB'));
                          Severity: Minor
                          Found in fannie/ordering/OrderViewPage.php - About 1 hr to fix

                            Method createEmptyOrder has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                private function createEmptyOrder()
    {
        global $FANNIE_OP_DB,$TRANS,$FANNIE_SERVER_DBMS, $FANNIE_TRANS_DB;
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
                            Severity: Minor
                            Found in fannie/ordering/OrderViewPage.php - About 1 hr to fix

                              Function itemList has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  private function itemList($orderID,$table="PendingSpecialOrder")
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $TRANS = $this->config->get('TRANS_DB') . $dbc->sep();
                              Severity: Minor
                              Found in fannie/ordering/OrderViewPage.php - About 1 hr to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function post_orderID_noteDept_noteText_ph1_ph2_email_handler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  protected function post_orderID_noteDept_noteText_ph1_ph2_email_handler()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('TRANS_DB'));
                              Severity: Minor
                              Found in fannie/ordering/OrderViewPage.php - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function reprice has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  private function reprice($oid,$tid,$reg=false)
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $TRANS = $this->config->get('TRANS_DB') . $dbc->sep();
                              Severity: Minor
                              Found in fannie/ordering/OrderViewPage.php - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Similar blocks of code found in 4 locations. Consider refactoring.
                              Open

                                      if (file_exists("{$cachepath}{$username}.prints")) {
            $prints = unserialize(file_get_contents("{$cachepath}{$username}.prints"));
        } else {
            $fptr = fopen("{$cachepath}{$username}.prints",'w');
            fwrite($fptr,serialize($prints));
                              Severity: Major
                              Found in fannie/ordering/OrderViewPage.php and 3 other locations - About 45 mins to fix
                              fannie/ordering/NewSpecialOrdersPage.php on lines 55..61
                              fannie/ordering/ajax-calls.php on lines 893..899
                              fannie/ordering/clearinghouse.php on lines 63..69

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 95.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status