Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/purchasing/EditOnePurchaseOrder.php

Summary

Maintainability
F
3 days
Test Coverage
F
58%

File EditOnePurchaseOrder.php has 457 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op
Severity: Minor
Found in fannie/purchasing/EditOnePurchaseOrder.php - About 7 hrs to fix

    Method get_id_view has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function get_id_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $userID = FannieAuth::getUID($this->current_user);
    Severity: Major
    Found in fannie/purchasing/EditOnePurchaseOrder.php - About 2 hrs to fix

      Method itemListTab has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function itemListTab($orderID)
    {
        $poi = new PurchaseOrderItemsModel($this->connection);
        $poi->orderID($orderID);
        $poi->load();
      Severity: Major
      Found in fannie/purchasing/EditOnePurchaseOrder.php - About 2 hrs to fix

        Method get_id_search_handler has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function get_id_search_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $ret = array();
        Severity: Minor
        Found in fannie/purchasing/EditOnePurchaseOrder.php - About 1 hr to fix

          Method mergeSearchResult has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function mergeSearchResult($ret, $orderID, $dbc)
    {
        $storeP = $dbc->prepare('SELECT storeID FROM PurchaseOrder WHERE orderID=?');
        $storeID = $dbc->getValue($storeP, array($orderID));
          Severity: Minor
          Found in fannie/purchasing/EditOnePurchaseOrder.php - About 1 hr to fix

            Method post_id_sku_case_qty_handler has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function post_id_sku_case_qty_handler()
    {
        $poi = new PurchaseOrderItemsModel($this->connection);
        $poi->orderID($this->id);
        $offset = FormLib::get('listOffset', 0);
            Severity: Minor
            Found in fannie/purchasing/EditOnePurchaseOrder.php - About 1 hr to fix

              Method get_id_sku_qty_handler has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function get_id_sku_qty_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $orderID = $this->id;
              Severity: Minor
              Found in fannie/purchasing/EditOnePurchaseOrder.php - About 1 hr to fix

                Function post_id_sku_case_qty_handler has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function post_id_sku_case_qty_handler()
    {
        $poi = new PurchaseOrderItemsModel($this->connection);
        $poi->orderID($this->id);
        $offset = FormLib::get('listOffset', 0);
                Severity: Minor
                Found in fannie/purchasing/EditOnePurchaseOrder.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method get_view has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function get_view()
    {
        global $FANNIE_OP_DB;
        $model = new VendorsModel(FannieDB::get($FANNIE_OP_DB));
        $vOpts = $model->toOptions();
                Severity: Minor
                Found in fannie/purchasing/EditOnePurchaseOrder.php - About 1 hr to fix

                  Function mergeSearchResult has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function mergeSearchResult($ret, $orderID, $dbc)
    {
        $storeP = $dbc->prepare('SELECT storeID FROM PurchaseOrder WHERE orderID=?');
        $storeID = $dbc->getValue($storeP, array($orderID));
                  Severity: Minor
                  Found in fannie/purchasing/EditOnePurchaseOrder.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          while($w = $dbc->fetch_row($skuR)){
            $result = array(
            'sku' => $w['sku'],
            'title' => $this->asciiFilter($w['brand']).' - '. $this->asciiFilter($w['description']),
            'unitSize' => $w['size'],
                  Severity: Major
                  Found in fannie/purchasing/EditOnePurchaseOrder.php and 1 other location - About 3 hrs to fix
                  fannie/purchasing/EditOnePurchaseOrder.php on lines 95..106

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 142.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          while($w = $dbc->fetch_row($upcR)){
            $result = array(
            'sku' => $w['sku'],
            'title' => $this->asciiFilter($w['brand']).' - '. $this->asciiFilter($w['description']),
            'unitSize' => $w['size'],
                  Severity: Major
                  Found in fannie/purchasing/EditOnePurchaseOrder.php and 1 other location - About 3 hrs to fix
                  fannie/purchasing/EditOnePurchaseOrder.php on lines 73..84

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 142.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status