CORE-POS/IS4C

View on GitHub
fannie/purchasing/InvoiceCostCompare.php

Summary

Maintainability
C
7 hrs
Test Coverage
F
3%

Method get_vendors_date1_date2_view has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_vendors_date1_date2_view()
    {
        $dbc = $this->connection;
        $dbc->setDefaultDB($this->config->get('OP_DB'));

Severity: Major
Found in fannie/purchasing/InvoiceCostCompare.php - About 3 hrs to fix

    Function get_vendors_date1_date2_view has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function get_vendors_date1_date2_view()
        {
            $dbc = $this->connection;
            $dbc->setDefaultDB($this->config->get('OP_DB'));
    
    
    Severity: Minor
    Found in fannie/purchasing/InvoiceCostCompare.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method post_view has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function post_view()
        {
            $dbc = $this->connection;
            $dbc->setDefaultDB($this->config->get('OP_DB'));
    
    
    Severity: Minor
    Found in fannie/purchasing/InvoiceCostCompare.php - About 1 hr to fix

      Function post_view has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function post_view()
          {
              $dbc = $this->connection;
              $dbc->setDefaultDB($this->config->get('OP_DB'));
      
      
      Severity: Minor
      Found in fannie/purchasing/InvoiceCostCompare.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status