Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/purchasing/importers/UsFoodsInvoiceImport.php

Summary

Maintainability
F
3 days
Test Coverage
F
0%

Function post_view has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
Open

    protected function post_view()
    {
        $file = $_FILES['invoice']['tmp_name'];
        $type = $_FILES['invoice']['type'];
        $store = FormLib::get('store');
Severity: Minor
Found in fannie/purchasing/importers/UsFoodsInvoiceImport.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method post_view has 107 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function post_view()
    {
        $file = $_FILES['invoice']['tmp_name'];
        $type = $_FILES['invoice']['type'];
        $store = FormLib::get('store');
Severity: Major
Found in fannie/purchasing/importers/UsFoodsInvoiceImport.php - About 4 hrs to fix

    Method updatePO has 12 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        private function updatePO($orderID, $shipDate, $ordered, $shipped, $sku, $upc, $item, $brand, $size, $units, $price, $fullPrice)
    Severity: Major
    Found in fannie/purchasing/importers/UsFoodsInvoiceImport.php - About 1 hr to fix

      Method updateCatalog has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private function updateCatalog($vendor, $sku, $item, $brand, $size, $units, $price, $doUpdates)
      Severity: Major
      Found in fannie/purchasing/importers/UsFoodsInvoiceImport.php - About 1 hr to fix

        Function updateCatalog has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function updateCatalog($vendor, $sku, $item, $brand, $size, $units, $price, $doUpdates)
    {
        if (!$this->vfindP) {
            $this->vfindP = $this->connection->prepare("SELECT upc FROM vendorItems WHERE vendorID=? AND sku=?");
        }
        Severity: Minor
        Found in fannie/purchasing/importers/UsFoodsInvoiceImport.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        if ($priceType == 'LB') {
                    $size = '#';
                    $units = str_replace(' LBA', '', $sizeInfo);
                    $mult = 1;
                    if (strstr($units, '/')) {
        Severity: Major
        Found in fannie/purchasing/importers/UsFoodsInvoiceImport.php and 1 other location - About 4 hrs to fix
        fannie/modules/plugins2.0/USFoodsInvoiceGrabber/USFTask.php on lines 77..103

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 174.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 5 locations. Consider refactoring.
        Open

            private function cleanUPC($upc)
    {
        if (strlen($upc) == 5 && substr($upc, 0, 1) == '9' && $upc !== '99999') {
            return BarcodeLib::padUPC(substr($upc, 1));
        }
        Severity: Major
        Found in fannie/purchasing/importers/UsFoodsInvoiceImport.php and 4 other locations - About 4 hrs to fix
        fannie/batches/UNFI/load-classes/AlbertsUploadPage.php on lines 82..96
        fannie/modules/plugins2.0/USFoodsInvoiceGrabber/USFTask.php on lines 272..286
        fannie/purchasing/importers/AlbertsInvoiceImport.php on lines 101..115
        fannie/purchasing/importers/RdwInvoiceImport.php on lines 134..148

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 172.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        } elseif ($priceType == 'CS') {
                    if (strstr($sizeInfo, '/')) {
                        list($units, $size) = explode('/', $sizeInfo, 2);
                    } else {
                        list($units, $size) = explode(' ', $sizeInfo, 2);
        Severity: Minor
        Found in fannie/purchasing/importers/UsFoodsInvoiceImport.php and 1 other location - About 55 mins to fix
        fannie/modules/plugins2.0/USFoodsInvoiceGrabber/USFTask.php on lines 95..103

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status