Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/reports/DepartmentMovement/SmartMovementReport.php

Summary

Maintainability
F
4 days
Test Coverage
F
22%

Method fetch_report_data has 127 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function fetch_report_data()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $query = '';
Severity: Major
Found in fannie/reports/DepartmentMovement/SmartMovementReport.php - About 5 hrs to fix

    Function report_description_content has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        public function report_description_content()
    {
        if ($this->report_format != 'html') {
            return array();
        }
    Severity: Minor
    Found in fannie/reports/DepartmentMovement/SmartMovementReport.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File SmartMovementReport.php has 312 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2014 Whole Foods Co-op
    Severity: Minor
    Found in fannie/reports/DepartmentMovement/SmartMovementReport.php - About 3 hrs to fix

      Method report_description_content has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function report_description_content()
    {
        if ($this->report_format != 'html') {
            return array();
        }
      Severity: Minor
      Found in fannie/reports/DepartmentMovement/SmartMovementReport.php - About 1 hr to fix

        Method calculate_footers has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function calculate_footers($data)
    {
        switch ($this->mode) {
            case 'PLU':
                $this->report_headers = array('UPC','Brand','Description','Rings','Qty','$',
        Severity: Minor
        Found in fannie/reports/DepartmentMovement/SmartMovementReport.php - About 1 hr to fix

          Function fetch_report_data has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function fetch_report_data()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $query = '';
          Severity: Minor
          Found in fannie/reports/DepartmentMovement/SmartMovementReport.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method form_content has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function form_content()
    {
        ob_start();
        ?>
        <form method="get" action="<?php echo $_SERVER['PHP_SELF']; ?>">
          Severity: Minor
          Found in fannie/reports/DepartmentMovement/SmartMovementReport.php - About 1 hr to fix

            Function calculate_footers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function calculate_footers($data)
    {
        switch ($this->mode) {
            case 'PLU':
                $this->report_headers = array('UPC','Brand','Description','Rings','Qty','$',
            Severity: Minor
            Found in fannie/reports/DepartmentMovement/SmartMovementReport.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                public function report_description_content()
    {
        if ($this->report_format != 'html') {
            return array();
        }
            Severity: Major
            Found in fannie/reports/DepartmentMovement/SmartMovementReport.php and 3 other locations - About 1 day to fix
            fannie/reports/DDD/SmartDDDReport.php on lines 47..101
            fannie/reports/DepartmentMovement/ReducedMovementReport.php on lines 41..95
            fannie/reports/Trends/TrendsReport.php on lines 40..90

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 356.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            $cols = $dbc->dayofweek("tdate")." AS dayNumber,CASE 
                    WHEN ".$dbc->dayofweek("tdate")."=1 THEN 'Sun'
                    WHEN ".$dbc->dayofweek("tdate")."=2 THEN 'Mon'
                    WHEN ".$dbc->dayofweek("tdate")."=3 THEN 'Tue'
                    WHEN ".$dbc->dayofweek("tdate")."=4 THEN 'Wed'
            Severity: Major
            Found in fannie/reports/DepartmentMovement/SmartMovementReport.php and 1 other location - About 1 hr to fix
            fannie/reports/DepartmentMovement/DepartmentMovementReport.php on lines 190..198

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status