Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/reports/EquitySales/EquitySalesReport.php

Summary

Maintainability
F
3 days
Test Coverage
F
50%

File EquitySalesReport.php has 526 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2012 Whole Foods Co-op
Severity: Major
Found in fannie/reports/EquitySales/EquitySalesReport.php - About 1 day to fix

    Method fetch_report_data has 145 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function fetch_report_data()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $data = array();
    Severity: Major
    Found in fannie/reports/EquitySales/EquitySalesReport.php - About 5 hrs to fix

      Method form_content has 142 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function form_content()
    {
        $storepicker = FormLib::storePicker();
        $store = FormLib::get('store');
        $datepicker = FormLib::date_range_picker();
      Severity: Major
      Found in fannie/reports/EquitySales/EquitySalesReport.php - About 5 hrs to fix

        Function fetch_report_data has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
        Open

            public function fetch_report_data()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $data = array();
        Severity: Minor
        Found in fannie/reports/EquitySales/EquitySalesReport.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method javascriptContent has 71 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function javascriptContent()
    {
        if ($this->report_format != 'html') {
            return;
        }
        Severity: Major
        Found in fannie/reports/EquitySales/EquitySalesReport.php - About 2 hrs to fix

          Method css_content has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function css_content()
    {
        return <<<CSS
.form-group  {
    margin: 15px;
          Severity: Minor
          Found in fannie/reports/EquitySales/EquitySalesReport.php - About 1 hr to fix

            Function form_content has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function form_content()
    {
        $storepicker = FormLib::storePicker();
        $store = FormLib::get('store');
        $datepicker = FormLib::date_range_picker();
            Severity: Minor
            Found in fannie/reports/EquitySales/EquitySalesReport.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    while ($row = $dbc->fetchRow($result)) {
            unset($temp);
            $date = $row['date'];
            $date = new DateTime($date);
            $date = $date->format('Y-m-d');
            Severity: Minor
            Found in fannie/reports/EquitySales/EquitySalesReport.php and 1 other location - About 45 mins to fix
            fannie/reports/EquitySales/EquitySalesReport.php on lines 205..213

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 96.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        while ($row = $dbc->fetchRow($result)) {
                unset($tempB);
                $date = $row['date'];
                $date = new DateTime($date);
                $date = $date->format('Y-m-d');
            Severity: Minor
            Found in fannie/reports/EquitySales/EquitySalesReport.php and 1 other location - About 45 mins to fix
            fannie/reports/EquitySales/EquitySalesReport.php on lines 149..157

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 96.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status