Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/reports/GeneralSales/GeneralSalesReport.php

Summary

Maintainability
C
1 day
Test Coverage
C
76%

File GeneralSalesReport.php has 252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op
Severity: Minor
Found in fannie/reports/GeneralSales/GeneralSalesReport.php - About 2 hrs to fix

    Method form_content has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function form_content()
    {
        list($lastMonday, $lastSunday) = \COREPOS\Fannie\API\lib\Dates::lastWeek();
        $store = FormLib::storePicker();
        ob_start();
    Severity: Minor
    Found in fannie/reports/GeneralSales/GeneralSalesReport.php - About 1 hr to fix

      Method toReportData has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function toReportData($supers, $grandTotal)
    {
        $data = array();
        $num = 1;
        foreach ($supers as $s) {
      Severity: Minor
      Found in fannie/reports/GeneralSales/GeneralSalesReport.php - About 1 hr to fix

        Method fetch_report_data has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function fetch_report_data()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $date1 = $this->form->date1;
        Severity: Minor
        Found in fannie/reports/GeneralSales/GeneralSalesReport.php - About 1 hr to fix

          Method nowQuery has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function nowQuery($dbc, $dlog, $store)
    {
        $sales = "SELECT 
            CASE WHEN e.dept_name IS NULL THEN d.dept_name ELSE e.dept_name end AS dept_name,
            sum(t.total) AS ttl,
          Severity: Minor
          Found in fannie/reports/GeneralSales/GeneralSalesReport.php - About 1 hr to fix

            Function toReportData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private function toReportData($supers, $grandTotal)
    {
        $data = array();
        $num = 1;
        foreach ($supers as $s) {
            Severity: Minor
            Found in fannie/reports/GeneralSales/GeneralSalesReport.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status