Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/reports/NonMovement/NonMovementReport.php

Summary

Maintainability
C
7 hrs
Test Coverage
D
68%

Method fetch_report_data has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function fetch_report_data()
    {
        global $FANNIE_OP_DB, $FANNIE_ARCHIVE_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $date1 = $this->form->date1;
Severity: Major
Found in fannie/reports/NonMovement/NonMovementReport.php - About 2 hrs to fix

    Method form_content has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function form_content()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $deptsQ = $dbc->prepare("select dept_no,dept_name from departments order by dept_no");
    Severity: Major
    Found in fannie/reports/NonMovement/NonMovementReport.php - About 2 hrs to fix

      Method preprocess has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function preprocess()
    {
        global $FANNIE_OP_DB;

        // custom: can delete items from report results
      Severity: Minor
      Found in fannie/reports/NonMovement/NonMovementReport.php - About 1 hr to fix

        Function fetch_report_data has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            function fetch_report_data()
    {
        global $FANNIE_OP_DB, $FANNIE_ARCHIVE_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $date1 = $this->form->date1;
        Severity: Minor
        Found in fannie/reports/NonMovement/NonMovementReport.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function preprocess has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            function preprocess()
    {
        global $FANNIE_OP_DB;

        // custom: can delete items from report results
        Severity: Minor
        Found in fannie/reports/NonMovement/NonMovementReport.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status