Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/reports/OwnerJoinLeave/OwnerJoinLeaveReport.php

Summary

Maintainability
F
4 days
Test Coverage
F
31%

Method fetch_report_data has 373 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function fetch_report_data()
    {
        global $FANNIE_OP_DB, $FANNIE_TRANS_DB;
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
Severity: Major
Found in fannie/reports/OwnerJoinLeave/OwnerJoinLeaveReport.php - About 1 day to fix

    Function fetch_report_data has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
    Open

        public function fetch_report_data()
    {
        global $FANNIE_OP_DB, $FANNIE_TRANS_DB;
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
    Severity: Minor
    Found in fannie/reports/OwnerJoinLeave/OwnerJoinLeaveReport.php - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File OwnerJoinLeaveReport.php has 478 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2014 Whole Foods Co-op
    Severity: Minor
    Found in fannie/reports/OwnerJoinLeave/OwnerJoinLeaveReport.php - About 7 hrs to fix

      Method franAmount has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function franAmount($dbc, $cardno)
    {
        if (!isset($this->stockP)) {
            $this->stockP = $dbc->prepare('SELECT tdate, stockPurchase, trans_num
                FROM ' . FannieDB::fqn('stockpurchases', 'trans') . '
      Severity: Minor
      Found in fannie/reports/OwnerJoinLeave/OwnerJoinLeaveReport.php - About 1 hr to fix

        Function franAmount has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function franAmount($dbc, $cardno)
    {
        if (!isset($this->stockP)) {
            $this->stockP = $dbc->prepare('SELECT tdate, stockPurchase, trans_num
                FROM ' . FannieDB::fqn('stockpurchases', 'trans') . '
        Severity: Minor
        Found in fannie/reports/OwnerJoinLeave/OwnerJoinLeaveReport.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                array_unshift($data, array(
            'Year to Date: ' . date('Y-m-d', strtotime($ytdArgs[0])) . ' - ' . date('Y-m-d', strtotime($ytdArgs[1])),
            null,
            $ytd['numOwners'],
            '',
        Severity: Minor
        Found in fannie/reports/OwnerJoinLeave/OwnerJoinLeaveReport.php and 1 other location - About 55 mins to fix
        fannie/reports/OwnerJoinLeave/OwnerJoinLeaveReport.php on lines 272..279

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                array_unshift($data, array(
            'Current Report: ' . date('Y-m-d', strtotime($args[0])) . ' - ' . date('Y-m-d', strtotime($args[1])),
            null,
            $totals['new'],
            '',
        Severity: Minor
        Found in fannie/reports/OwnerJoinLeave/OwnerJoinLeaveReport.php and 1 other location - About 55 mins to fix
        fannie/reports/OwnerJoinLeave/OwnerJoinLeaveReport.php on lines 263..270

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status