Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/reports/PatronageOverDates/PatronageOverDatesReport.php

Summary

Maintainability
D
1 day
Test Coverage
F
42%

Method fetch_report_data has 104 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function fetch_report_data(){
        global $FANNIE_OP_DB, $FANNIE_COOP_ID,
             $FANNIE_TRANS_DB, $FANNIE_URL;

        try {
Severity: Major
Found in fannie/reports/PatronageOverDates/PatronageOverDatesReport.php - About 4 hrs to fix

    Function fetch_report_data has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        function fetch_report_data(){
        global $FANNIE_OP_DB, $FANNIE_COOP_ID,
             $FANNIE_TRANS_DB, $FANNIE_URL;

        try {
    Severity: Minor
    Found in fannie/reports/PatronageOverDates/PatronageOverDatesReport.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File PatronageOverDatesReport.php has 261 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

     <?php
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op
    Copyright 2015 West End Food Co-op, Toronto
    Severity: Minor
    Found in fannie/reports/PatronageOverDates/PatronageOverDatesReport.php - About 2 hrs to fix

      Method calculate_footers has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function calculate_footers($data)
    {
        // no data; don't bother
        if (empty($data)) {
            return array();
      Severity: Major
      Found in fannie/reports/PatronageOverDates/PatronageOverDatesReport.php - About 2 hrs to fix

        Method form_content has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function form_content()
    {
        ob_start();
        list($lastMonday, $lastSunday) = \COREPOS\Fannie\API\lib\Dates::lastWeek();
        Severity: Minor
        Found in fannie/reports/PatronageOverDates/PatronageOverDatesReport.php - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status