Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/reports/Paycards/PcDailyReport.php

Summary

Maintainability
F
6 days
Test Coverage
F
33%

Method fetch_report_data has 219 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function fetch_report_data()
    {
        $date_id = date('Ymd', strtotime(FormLib::get('date', date('Y-m-d'))));
        $date_str = date('Y-m-d', strtotime(FormLib::get('date', date('Y-m-d'))));
        $store = FormLib::get('store', false);
Severity: Major
Found in fannie/reports/Paycards/PcDailyReport.php - About 1 day to fix

    Function fetch_report_data has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

        public function fetch_report_data()
    {
        $date_id = date('Ymd', strtotime(FormLib::get('date', date('Y-m-d'))));
        $date_str = date('Y-m-d', strtotime(FormLib::get('date', date('Y-m-d'))));
        $store = FormLib::get('store', false);
    Severity: Minor
    Found in fannie/reports/Paycards/PcDailyReport.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File PcDailyReport.php has 392 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op
    Severity: Minor
    Found in fannie/reports/Paycards/PcDailyReport.php - About 5 hrs to fix

      Method getTransactions has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getTransactions($date_id, $store, $processor, $invertReturns=false)
    {
        // voids have trans_id from original dtrans record, not void dtrans record
        $invert = $invertReturns ? "'VOID','Return'" : "'VOID'";
        $mercuryQ = "
      Severity: Major
      Found in fannie/reports/Paycards/PcDailyReport.php - About 2 hrs to fix

        Function getTransactions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function getTransactions($date_id, $store, $processor, $invertReturns=false)
    {
        // voids have trans_id from original dtrans record, not void dtrans record
        $invert = $invertReturns ? "'VOID','Return'" : "'VOID'";
        $mercuryQ = "
        Severity: Minor
        Found in fannie/reports/Paycards/PcDailyReport.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method procToDataset has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function procToDataset($dataset, $proc, $name)
    {
        foreach ($proc as $type => $info) {
            $record = array($name, 
                        $type,
        Severity: Minor
        Found in fannie/reports/Paycards/PcDailyReport.php - About 1 hr to fix

          Method calculate_footers has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function calculate_footers($data) {
        $pN = 0;
        $pS = 0.0;
        $tN = 0;
        $tS = 0.0;
          Severity: Minor
          Found in fannie/reports/Paycards/PcDailyReport.php - About 1 hr to fix

            Function calculate_footers has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function calculate_footers($data) {
        $pN = 0;
        $pS = 0.0;
        $tN = 0;
        $tS = 0.0;
            Severity: Minor
            Found in fannie/reports/Paycards/PcDailyReport.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach($proc as $type => $info) {
            $record = array('POS Total', 
                            $type, 
                            $info['Sales']['num'],
                            sprintf('%.2f', $info['Sales']['amt']),
            Severity: Major
            Found in fannie/reports/Paycards/PcDailyReport.php and 1 other location - About 2 days to fix
            fannie/reports/Paycards/PcMonthlyReport.php on lines 342..376

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 473.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        foreach($info['Details'] as $issuer => $subinfo) {
                $record = array('', 
                                $issuer, 
                                $subinfo['Sales']['num'],
                                sprintf('%.2f', $subinfo['Sales']['amt']),
            Severity: Major
            Found in fannie/reports/Paycards/PcDailyReport.php and 2 other locations - About 3 hrs to fix
            fannie/reports/Paycards/PcMonthlyReport.php on lines 159..170
            fannie/reports/Paycards/PcMonthlyReport.php on lines 242..253

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 155.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (!isset($proc[$cardType])) {
                $proc[$cardType] = array(
                            'Sales' => array('amt'=>0.0, 'num'=>0),
                            'Returns' => array('amt'=>0.0, 'num'=>0),
                            'Integrated' => array(
            Severity: Major
            Found in fannie/reports/Paycards/PcDailyReport.php and 1 other location - About 2 hrs to fix
            fannie/reports/Paycards/PcMonthlyReport.php on lines 291..304

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 133.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ($proc as $type => $info) {
            foreach ($info['Details'] as $issuer => $subinfo) {
                if ($issuer == 'AMEX') {
                    $recon['Amex'] += ($subinfo['Sales']['amt'] + $subinfo['Returns']['amt']);
                } else {
            Severity: Minor
            Found in fannie/reports/Paycards/PcDailyReport.php and 1 other location - About 40 mins to fix
            fannie/reports/Paycards/PcDailyReport.php on lines 191..199

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 94.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ($proc as $type => $info) {
            foreach ($info['Details'] as $issuer => $subinfo) {
                if ($issuer == 'American Express') {
                    $recon['Amex'] += ($subinfo['Sales']['amt'] + $subinfo['Returns']['amt']);
                } else {
            Severity: Minor
            Found in fannie/reports/Paycards/PcDailyReport.php and 1 other location - About 40 mins to fix
            fannie/reports/Paycards/PcDailyReport.php on lines 179..187

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 94.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status