Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/reports/ScaleItems/ScaleItemsReport.php

Summary

Maintainability
B
5 hrs
Test Coverage
C
72%

Method fetch_report_data has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function fetch_report_data()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $model = new ScaleItemsModel($dbc);
Severity: Minor
Found in fannie/reports/ScaleItems/ScaleItemsReport.php - About 2 hrs to fix

    Method form_content has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function form_content()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $model = new DepartmentsModel($dbc);
    Severity: Minor
    Found in fannie/reports/ScaleItems/ScaleItemsReport.php - About 1 hr to fix

      Function fetch_report_data has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function fetch_report_data()
    {
        $dbc = $this->connection;
        $dbc->selectDB($this->config->get('OP_DB'));
        $model = new ScaleItemsModel($dbc);
      Severity: Minor
      Found in fannie/reports/ScaleItems/ScaleItemsReport.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status