CORE-POS/IS4C

View on GitHub
fannie/reports/Store-Specific/WFC/EOMreport/taxonly.php

Summary

Maintainability
F
1 wk
Test Coverage

File taxonly.php has 328 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
use COREPOS\Fannie\API\item\StandardAccounting;
//header('Content-Type: application/ms-excel');
//header('Content-Disposition: attachment; filename="EOMreport.xls"');
include('../../../../config.php');
Severity: Minor
Found in fannie/reports/Store-Specific/WFC/EOMreport/taxonly.php - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if ($store == 50) {
            for ($i=1; $i<=2; $i++) {
                $tranP = $sql->prepare("SELECT YEAR(tdate), MONTH(tdate), DAY(tdate), emp_no, register_no, trans_no
                    FROM {$dlog} WHERE trans_subtype='CM' AND description='STORE {$i}'
                        AND tdate BETWEEN ? AND ?
    Severity: Major
    Found in fannie/reports/Store-Specific/WFC/EOMreport/taxonly.php and 1 other location - About 1 wk to fix
    fannie/reports/Store-Specific/WFC/EOMreport/index.php on lines 441..701

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 1388.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    if (isset($_GET["excel"])){
    header('Content-Type: application/ms-excel');
    header('Content-Disposition: attachment; filename="EOMreport.xls"');
    $_SERVER['REQUEST_URI'] = $_SERVER['PHP_SELF']; // grab excel from cache
    $_SERVER['REQUEST_URI'] = str_replace("taxonly.php","",$_SERVER['REQUEST_URI']);
    Severity: Major
    Found in fannie/reports/Store-Specific/WFC/EOMreport/taxonly.php and 1 other location - About 1 hr to fix
    fannie/reports/Store-Specific/WFC/EOMreport/index.php on lines 12..24

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 5 locations. Consider refactoring.
    Open

    if ($store === false) {
        $clientIP = filter_input(INPUT_SERVER, 'REMOTE_ADDR');
        foreach ($FANNIE_STORE_NETS as $storeID => $range) {
            if (
                class_exists('\\Symfony\\Component\\HttpFoundation\\IpUtils')
    Severity: Major
    Found in fannie/reports/Store-Specific/WFC/EOMreport/taxonly.php and 4 other locations - About 35 mins to fix
    fannie/reports/Store-Specific/WFC/DailyReport/index.php on lines 64..77
    fannie/reports/Store-Specific/WFC/EOM-Nabs/anydate.php on lines 43..56
    fannie/reports/Store-Specific/WFC/EOM-Nabs/index.php on lines 29..42
    fannie/reports/Store-Specific/WFC/EOMreport/index.php on lines 27..40

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 92.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status