CORE-POS/IS4C

View on GitHub
fannie/reports/VendorMovement/VendorMovementReport.php

Summary

Maintainability
C
1 day
Test Coverage
F
36%

Method getQuery has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getQuery($groupby, $store, $dlog)
    {
        switch ($groupby) {
            case 'upc':
            default:
Severity: Major
Found in fannie/reports/VendorMovement/VendorMovementReport.php - About 2 hrs to fix

    Method form_content has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function form_content()
        {
            $this->addScript('../../item/autocomplete.js');
            $vendor = new VendorsModel($this->connection);
            ob_start();
    Severity: Major
    Found in fannie/reports/VendorMovement/VendorMovementReport.php - About 2 hrs to fix

      Function fetch_report_data has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function fetch_report_data()
          {
              $dbc = $this->connection;
              $dbc->selectDB($this->config->get('OP_DB'));
              try {
      Severity: Minor
      Found in fannie/reports/VendorMovement/VendorMovementReport.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method fetch_report_data has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function fetch_report_data()
          {
              $dbc = $this->connection;
              $dbc->selectDB($this->config->get('OP_DB'));
              try {
      Severity: Minor
      Found in fannie/reports/VendorMovement/VendorMovementReport.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status