Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/src/defaultmenu.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    array('label'=>'Sales >>','url'=>'reports/',
        'submenu'=>array(
            array('label'=>'General Sales Report','url'=>'reports/GeneralSales/'),
            array('label'=>'General Cost Report','url'=>'reports/GeneralCost/'),
            array('label'=>'Sales Today','url'=>'reports/SalesToday/'),
Severity: Minor
Found in fannie/src/defaultmenu.php and 2 other locations - About 30 mins to fix
fannie/src/defaultmenu.php on lines 159..167
fannie/src/defaultmenu.php on lines 169..177

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    array('label'=>'Email Statements >>','url'=>'mem/statements/',
    'submenu'=>array(
        array('label'=>'AR (Member)','url'=>'mem/statements/indvAR.php'),
        array('label'=>'AR (Business EOM)','url'=>'mem/statements/busAR.php'),
        array('label'=>'AR (Business Any Balance)','url'=>'mem/statements/busAR.php'),
Severity: Minor
Found in fannie/src/defaultmenu.php and 2 other locations - About 30 mins to fix
fannie/src/defaultmenu.php on lines 101..109
fannie/src/defaultmenu.php on lines 169..177

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    array('label'=>'Special Orders >>','url'=>'ordering/',
    'submenu'=>array(
        array('label'=>'Create Order','url'=>'ordering/view.php'),
        array('label'=>'Review Active Orders','url'=>'ordering/clearinghouse.php'),
        array('label'=>'Review Old Orders','url'=>'ordering/historical.php'),
Severity: Minor
Found in fannie/src/defaultmenu.php and 2 other locations - About 30 mins to fix
fannie/src/defaultmenu.php on lines 101..109
fannie/src/defaultmenu.php on lines 159..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status