Sign upLogin

CORE-POS/IS4C

View on GitHub
Star

Showing 8,683 of 8,684 total issues

Function searchCustdata has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    private static function searchCustdata($dbc, $json, $limit=0, $minimal=false)
    {
        $query = '
            SELECT c.CardNo AS cardNo,
                ' . ($minimal ? 'c.FirstName' : 'MAX(c.FirstName)') . ' AS firstName,
Severity: Minor
Found in fannie/classlib2.0/member/MemberREST.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function push has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function push($tableName, $dbName, $includeOffline=false)
    {
        $ret = array('success'=>true, 'details'=>'');
        $dbc = FannieDB::get($this->config->get('OP_DB'));
        $model = new TendersModel($dbc);
Severity: Minor
Found in fannie/classlib2.0/data/lanesync/TendersSync.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getHeader has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function getHeader()
    {
        $url = $this->config->get('URL');
        ob_start();
        $page_title = $this->title;
Severity: Minor
Found in fannie/classlib2.0/FanniePage.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function drawItem has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    protected function drawItem($pdf, $item, $row, $column)
    {
        $item['description'] = preg_replace("/[^\x01-\x7F]/"," ", $item['description']);
        $item['description'] = str_replace("  ", " ", $item['description']);
        $effective_width = $this->width - $this->left;
Severity: Minor
Found in fannie/classlib2.0/item/signage/Signage12UpL.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function drawItem has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    protected function drawItem($pdf, $item, $row, $column)
    {
        $item['description'] = preg_replace("/[^\x01-\x7F]/"," ", $item['description']);
        $item['description'] = str_replace("  ", " ", $item['description']);
        $effective_width = $this->width - $this->left;
Severity: Minor
Found in fannie/classlib2.0/item/signage/Compact12UpL.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function post_sendall_handler has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    function post_sendall_handler()
    {
        global $FANNIE_OP_DB;
        $model = new ScaleItemsModel(FannieDB::get($FANNIE_OP_DB));
        $upcs = FormLib::get('upcs', array());
Severity: Minor
Found in fannie/item/hobartcsv/SyncFromSearch.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function post_id_sku_field_value_handler has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function post_id_sku_field_value_handler()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
        $item = new VendorItemsModel($dbc);
Severity: Minor
Found in fannie/item/vendors/EditVendorItems.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getVendorInfo has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    private function getVendorInfo($id)
    {
        $dbc = FannieDB::get($this->config->get('OP_DB'));
        $ret = "";
        $noEdit = !$this->canEdit ? 'disabled' : '';
Severity: Minor
Found in fannie/item/vendors/VendorIndexPage.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function AjaxCallback has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    function AjaxCallback()
    {
        $likecode = FormLib::get('lc',-1);
        $newLC = FormLib::get('newLC', false);
        $json = array();
Severity: Minor
Found in fannie/item/modules/LikeCodeModule.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function post_newbatch_tags_upcs_newprices_handler has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    function post_newbatch_tags_upcs_newprices_handler()
    {
        global $FANNIE_OP_DB, $FANNIE_URL;
        $this->upcs = json_decode($this->upcs);
        $this->newprices = json_decode($this->newprices);
Severity: Minor
Found in fannie/item/MarginToolFromSearch.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_start_view has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    function get_start_view()
    {
        global $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_OP_DB);
Severity: Minor
Found in fannie/item/ProdLocationEditor.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function MarginFS has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

function MarginFS($upc,$cost,$deptID)
{
    global $FANNIE_OP_DB;
    $dbc = FannieDB::get($FANNIE_OP_DB);
Severity: Minor
Found in fannie/item/ajax.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function saveFormData has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function saveFormData($upc)
    {
        $dbc = $this->db();
        try {
            $new_rule = $this->form->price_rule_id;
Severity: Minor
Found in fannie/item/modules/ItemMarginModule.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function normalizeRename has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    private function normalizeRename($db_name, $mode=BasicModel::NORMALIZE_MODE_CHECK)
    {
        $current = $this->connection->detailedDefinition($this->name);
        $dbms = $this->connection->dbmsName();
        $recase_columns = array();
Severity: Minor
Found in common/BasicModel.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method MergeEnumerableContent has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
Open

        internal static void MergeEnumerableContent(JContainer target, IEnumerable content, JsonMergeSettings settings)
        {
            switch (settings.MergeArrayHandling)
            {
                case MergeArrayHandling.Concat:
Severity: Minor
Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/Linq/JContainer.cs - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ConnectClient has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
Open

        private void ConnectClient(IAsyncResult state)
        {
            TcpClient client;
            try {
                TcpListener server = (TcpListener)state.AsyncState;
Severity: Minor
Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/WebSocketServer.cs - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

function queue_rm(val){
    var temp = new Array();
    for (var i = 0; i < editQueue.length; i++){
        if (editQueue[i] != val) temp.push(editQueue[i]);
    }
Severity: Major
Found in fannie/modules/plugins2.0/DeliInventory/index3.js and 1 other location - About 2 hrs to fix
fannie/modules/plugins2.0/DeliInventory/index.js on lines 200..206

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

function queue_rm(val){
    var temp = new Array();
    for (var i = 0; i < editQueue.length; i++){
        if (editQueue[i] != val) temp.push(editQueue[i]);
    }
Severity: Major
Found in fannie/modules/plugins2.0/DeliInventory/index.js and 1 other location - About 2 hrs to fix
fannie/modules/plugins2.0/DeliInventory/index3.js on lines 202..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function updateDepositAmount has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function updateDepositAmount(d){
    var val = 0;
    var count = 0;
    switch(d){
    case '10.00':
Severity: Major
Found in fannie/modules/plugins2.0/OverShortTools/js/count.js - About 2 hrs to fix

    Function emv has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var emv = (function($){
    var mod = {};

    var serverURL = 'http://localhost:8999';
    mod.setURL = function(url) {
    Severity: Major
    Found in pos/is4c-nf/plugins/Paycards/js/emv.js - About 2 hrs to fix
      Severity
      Category
      Status
      Source
      Language