Sign upLogin

CORE-POS/IS4C

View on GitHub
Star

Showing 8,683 of 8,684 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

function updateAAVariance(){
    var accountable = Number($('#cashInTillsTotal').html());
    var actual = Number($('#safeCount2Total').html());

    var variance = actual - accountable;
Severity: Major
Found in fannie/modules/plugins2.0/OverShortTools/js/countV3.js and 1 other location - About 6 hrs to fix
fannie/modules/plugins2.0/OverShortTools/js/countV2.js on lines 146..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 156.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method inner_form_content has 151 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function inner_form_content($owner='',$firstName='',$lastName='',
        $phone='',$address='',$uid='',$date='',$subject='',$content='',$complete='')
    {

        $dbc = FannieDB::get($this->config->get('OP_DB'));
Severity: Major
Found in fannie/modules/plugins2.0/CustomerServiceLog/CustomerServiceLog.php - About 6 hrs to fix

    Method ReadStringIntoBuffer has 151 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            private void ReadStringIntoBuffer(char quote)
        {
            int charPos = _charPos;
            int initialPosition = _charPos;
            int lastWritePosition = _charPos;
    Severity: Major
    Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/JsonTextReader.cs - About 6 hrs to fix

      File ObfBigBoardReport.php has 418 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

use COREPOS\Fannie\API\lib\Stats;
use COREPOS\Fannie\API\item\ItemText;
      Severity: Minor
      Found in fannie/modules/plugins2.0/OpenBookFinancingV2/ObfBigBoardReport.php - About 6 hrs to fix

        File NutriFactEntry.php has 418 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
/*******************************************************************************

    Copyright 2013 Whole Foods Community Co-op
        Severity: Minor
        Found in fannie/item/images/NutriFactEntry.php - About 6 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function saveInputs($dateStr,$store,$row,$data){
        global $FANNIE_PLUGIN_SETTINGS;
        $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['OverShortDatabase']);

        $model = new DailyDepositModel($dbc);
          Severity: Major
          Found in fannie/modules/plugins2.0/OverShortTools/OverShortSafecountPage.php and 1 other location - About 6 hrs to fix
          fannie/modules/plugins2.0/OverShortTools/OverShortSafecountV2.php on lines 85..108

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 204.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function saveInputs($dateStr,$store,$row,$data){
        global $FANNIE_PLUGIN_SETTINGS;
        $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['OverShortDatabase']);

        $model = new DailyDepositModel($dbc);
          Severity: Major
          Found in fannie/modules/plugins2.0/OverShortTools/OverShortSafecountV2.php and 1 other location - About 6 hrs to fix
          fannie/modules/plugins2.0/OverShortTools/OverShortSafecountPage.php on lines 85..108

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 204.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          AdvancedItemSearch has 44 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class AdvancedItemSearch extends FannieRESTfulPage
{
    protected $header = 'Advanced Search';
    protected $title = 'Advanced Search';
          Severity: Minor
          Found in fannie/item/AdvancedItemSearch.php - About 6 hrs to fix

            Class JObject has 44 methods (exceeds 20 allowed). Consider refactoring.
            Open

                public class JObject : JContainer, IDictionary<string, JToken>, INotifyPropertyChanged
#if !(NETFX_CORE || PORTABLE40 || PORTABLE)
        , ICustomTypeDescriptor
#endif
#if !(NET20 || NETFX_CORE || PORTABLE40 || PORTABLE)
            Severity: Minor
            Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/Linq/JObject.cs - About 6 hrs to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      while ($row = $this->connection->fetchRow($res)) {
            $code = $row['likeCode'];
            if (!isset($map[$code])) {
                $map[$code] = array(
                    'skus'=>array(),
              Severity: Major
              Found in fannie/item/likecodes/LikeCodeSKUsPage.php and 1 other location - About 5 hrs to fix
              fannie/item/likecodes/LikeCodeBatchPage.php on lines 306..323

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 203.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      while ($row = $this->connection->fetchRow($res)) {
            $code = $row['likeCode'];
            if (!isset($map[$code])) {
                $map[$code] = array(
                    'skus'=>array(),
              Severity: Major
              Found in fannie/item/likecodes/LikeCodeBatchPage.php and 1 other location - About 5 hrs to fix
              fannie/item/likecodes/LikeCodeSKUsPage.php on lines 234..251

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 203.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method javascript_content has 149 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function javascript_content()
    {
        $WfcDuluth = (FannieConfig::config('COOP_ID') == 'WFC_Duluth') ? 1 : 0;

        return <<<JAVASCRIPT
              Severity: Major
              Found in fannie/item/ItemEditorPage.php - About 5 hrs to fix

                Method ParseNumber has 149 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        private void ParseNumber()
        {
            ShiftBufferIfNeeded();

            char firstChar = _chars[_charPos];
                Severity: Major
                Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/JsonTextReader.cs - About 5 hrs to fix

                  File DepartmentDiscrepancyPage.php has 414 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
/*******************************************************************************

    Copyright 2013 Whole Foods Co-op, Duluth, MN
                  Severity: Minor
                  Found in fannie/item/DepartmentDiscrepancyPage.php - About 5 hrs to fix

                    Method WriteValue has 148 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            internal static void WriteValue(JsonWriter writer, PrimitiveTypeCode typeCode, object value)
        {
            switch (typeCode)
            {
                case PrimitiveTypeCode.Char:
                    Severity: Major
                    Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/JsonWriter.cs - About 5 hrs to fix

                      Function batchEdit has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                      Open

                      var batchEdit = (function ($) {
    var mod = {};

    var alerthi = function() {
        alert('hi');
                      Severity: Minor
                      Found in fannie/batches/newbatch/edit.js - About 5 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function body_content has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                      Open

                          function body_content()
    {
        global $FANNIE_AUTH_ENABLED;
        include(dirname(__FILE__) . '/../config.php');
                      Severity: Minor
                      Found in fannie/install/InstallAuthenticationPage.php - About 5 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function listClasses has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private function listClasses()
    {
        $FANNIE_URL = $this->config->get('URL');

        $dbc = FannieDB::get($this->config->get('OP_DB'));
                      Severity: Minor
                      Found in fannie/modules/plugins2.0/WfcClassRegistry/WfcClassRegistryPage.php - About 5 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function calculateHoldings has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private function calculateHoldings($endDate)
    {
        global $FANNIE_PLUGIN_SETTINGS, $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['GiveUsMoneyDB']);
                      Severity: Minor
                      Found in fannie/modules/plugins2.0/GiveUsMoneyPlugin/GumIssueDividendPage.php - About 5 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function fetch_report_data has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function fetch_report_data()
    {
        global $FANNIE_PLUGIN_SETTINGS, $FANNIE_OP_DB;
        $dbc = FannieDB::get($FANNIE_PLUGIN_SETTINGS['GiveUsMoneyDB']);
        $dt = FormLib::get('endDate', date('Y-m-d'));
                      Severity: Minor
                      Found in fannie/modules/plugins2.0/GiveUsMoneyPlugin/reports/GumDividendReport.php - About 5 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language