Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/gui-modules/QuantityEntryPage.php

Summary

Maintainability
C
1 day
Test Coverage
D
61%

Consider simplifying this complex logical expression.
Open

        if ($mode == self::MODE_VERBATIM && !is_numeric($qtty)) {
            $this->msg = _('invalid quantity<br />enter number');
            return true;
        } elseif ($mode == self::MODE_PRECISE && strpos($qtty, ".") == 2) {
            $this->boxColor="errorColoredArea";
Severity: Critical
Found in pos/is4c-nf/gui-modules/QuantityEntryPage.php - About 2 hrs to fix

    Method validateQty has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function validateQty($mode, $qtty)
    {
        /**
          If it's a number, check error conditions.
          The number should always be an integer. In
    Severity: Minor
    Found in pos/is4c-nf/gui-modules/QuantityEntryPage.php - About 1 hr to fix

      Function validateQty has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          private function validateQty($mode, $qtty)
    {
        /**
          If it's a number, check error conditions.
          The number should always be an integer. In
      Severity: Minor
      Found in pos/is4c-nf/gui-modules/QuantityEntryPage.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method preprocess has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function preprocess()
    {
        $this->boxColor="coloredArea";
        $this->msg = _("quantity required");
        $mode = $this->refineMode($this->form->tryGet('qty-mode'));
      Severity: Minor
      Found in pos/is4c-nf/gui-modules/QuantityEntryPage.php - About 1 hr to fix

        Function preprocess has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            function preprocess()
    {
        $this->boxColor="coloredArea";
        $this->msg = _("quantity required");
        $mode = $this->refineMode($this->form->tryGet('qty-mode'));
        Severity: Minor
        Found in pos/is4c-nf/gui-modules/QuantityEntryPage.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return true;
        Severity: Major
        Found in pos/is4c-nf/gui-modules/QuantityEntryPage.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $qtty;
          Severity: Major
          Found in pos/is4c-nf/gui-modules/QuantityEntryPage.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status