Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/gui-modules/RefundTransaction.php

Summary

Maintainability
B
5 hrs
Test Coverage
F
38%

Method body_content has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function body_content()
    {
        list($lines, $refundables) = $this->getLines();
        $rfIDs = implode(',', $refundables);
        $date = $this->form->tryGet('date');
Severity: Minor
Found in pos/is4c-nf/gui-modules/RefundTransaction.php - About 1 hr to fix

    Method getLines has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getLines()
    {
        $date = $this->form->tryGet('date');
        $txn = $this->form->tryGet('tn');
    Severity: Minor
    Found in pos/is4c-nf/gui-modules/RefundTransaction.php - About 1 hr to fix

      Function preprocess has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          function preprocess()
    {
        if ($this->form->tryGet('selectlist', false) !== false) {
            if (empty($this->form->selectlist)) {
                $this->change_page($this->page_url."gui-modules/pos2.php");
      Severity: Minor
      Found in pos/is4c-nf/gui-modules/RefundTransaction.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getLines has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getLines()
    {
        $date = $this->form->tryGet('date');
        $txn = $this->form->tryGet('tn');
      Severity: Minor
      Found in pos/is4c-nf/gui-modules/RefundTransaction.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status