Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/gui-modules/TransList.php

Summary

Maintainability
D
2 days
Test Coverage
D
69%

Method body_content has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function body_content()
    {
        ?>
        <div class="baseHeight">
        <div class="listbox">
Severity: Major
Found in pos/is4c-nf/gui-modules/TransList.php - About 2 hrs to fix

    Method getTransactions has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getTransactions()
    {
        $dbc = Database::tDataConnect();
        $filterQ = "SELECT description, emp_no, register_no, trans_no
            FROM localtranstoday
    Severity: Minor
    Found in pos/is4c-nf/gui-modules/TransList.php - About 1 hr to fix

      Method preprocess has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function preprocess()
    {
        if ($this->form->tryGet('selectlist', false) !== false) {
            if (!empty($this->form->selectlist)) {
                list($emp, $reg, $trans) = explode('::', $this->form->selectlist);
      Severity: Minor
      Found in pos/is4c-nf/gui-modules/TransList.php - About 1 hr to fix

        Function preprocess has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            function preprocess()
    {
        if ($this->form->tryGet('selectlist', false) !== false) {
            if (!empty($this->form->selectlist)) {
                list($emp, $reg, $trans) = explode('::', $this->form->selectlist);
        Severity: Minor
        Found in pos/is4c-nf/gui-modules/TransList.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            function body_content()
    {
        ?>
        <div class="baseHeight">
        <div class="listbox">
        Severity: Major
        Found in pos/is4c-nf/gui-modules/TransList.php and 2 other locations - About 1 day to fix
        pos/is4c-nf/gui-modules/giftReceiptList.php on lines 139..194
        pos/is4c-nf/gui-modules/rplist.php on lines 173..230

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 323.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            private function previewTrans($trans)
    {
        list($emp, $reg, $tID) = explode('::', $trans);
        $dbc = Database::tDataConnect();
        $previewP = $dbc->prepare("
        Severity: Major
        Found in pos/is4c-nf/gui-modules/TransList.php and 2 other locations - About 3 hrs to fix
        pos/is4c-nf/gui-modules/giftReceiptList.php on lines 113..137
        pos/is4c-nf/gui-modules/rplist.php on lines 147..171

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 146.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status