Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/install/buildLTTViews.php

Summary

Maintainability
C
1 day
Test Coverage

Method buildLTTViewsGeneric has 115 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function buildLTTViewsGeneric($db, $type, $errors=array())
{
    //--------------------------------------------------------------
    // CREATE lttSummary VIEW
    //--------------------------------------------------------------
Severity: Major
Found in pos/is4c-nf/install/buildLTTViews.php - About 4 hrs to fix

    Function buildLTTViewsGeneric has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    function buildLTTViewsGeneric($db, $type, $errors=array())
{
    //--------------------------------------------------------------
    // CREATE lttSummary VIEW
    //--------------------------------------------------------------
    Severity: Minor
    Found in pos/is4c-nf/install/buildLTTViews.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method fsTaxStr has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function fsTaxStr($desc, $rates)
{
    $fsTaxStr = "CASE WHEN ";
    for ($i = 0; $i < count($rates); $i++)
        $fsTaxStr .= "s.fsTaxable_".$desc[$i]."+";
    Severity: Minor
    Found in pos/is4c-nf/install/buildLTTViews.php - About 1 hr to fix

      Function fsTaxStr has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function fsTaxStr($desc, $rates)
{
    $fsTaxStr = "CASE WHEN ";
    for ($i = 0; $i < count($rates); $i++)
        $fsTaxStr .= "s.fsTaxable_".$desc[$i]."+";
      Severity: Minor
      Found in pos/is4c-nf/install/buildLTTViews.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status