Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/install/conf/FormFactory.php

Summary

Maintainability
D
2 days
Test Coverage

Function selectField has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    public function selectField($name, $options, $default_value='', $storage=Conf::EITHER_SETTING, $quoted=true, $attributes=array())
    {
        $current_value = $this->getCurrentValue($name, $default_value, $quoted);

        $is_array = false;
Severity: Minor
Found in pos/is4c-nf/install/conf/FormFactory.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function textField has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    public function textField($name, $default_value='', $storage=Conf::EITHER_SETTING, $quoted=true, $attributes=array(), $area=false)
    {
        $current_value = $this->getCurrentValue($name, $default_value, $quoted);

        // sanitize values:
Severity: Minor
Found in pos/is4c-nf/install/conf/FormFactory.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method textField has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function textField($name, $default_value='', $storage=Conf::EITHER_SETTING, $quoted=true, $attributes=array(), $area=false)
    {
        $current_value = $this->getCurrentValue($name, $default_value, $quoted);

        // sanitize values:
Severity: Minor
Found in pos/is4c-nf/install/conf/FormFactory.php - About 1 hr to fix

    Method selectField has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function selectField($name, $options, $default_value='', $storage=Conf::EITHER_SETTING, $quoted=true, $attributes=array())
    {
        $current_value = $this->getCurrentValue($name, $default_value, $quoted);

        $is_array = false;
    Severity: Minor
    Found in pos/is4c-nf/install/conf/FormFactory.php - About 1 hr to fix

      Function getCurrentValue has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getCurrentValue($name, $default_value, $quoted)
    {
        $current_value = \CoreLocal::get($name);
        if ($current_value === '') {
            $current_value = $default_value;
      Severity: Minor
      Found in pos/is4c-nf/install/conf/FormFactory.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

                  if ($is_array && $has_keys) {
                foreach ($current_value as $cv) {
                    if ($this->endMatch($key, $cv)) {
                        $selected = 'selected';
                    }
      Severity: Major
      Found in pos/is4c-nf/install/conf/FormFactory.php - About 1 hr to fix

        Method selectField has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function selectField($name, $options, $default_value='', $storage=Conf::EITHER_SETTING, $quoted=true, $attributes=array())
        Severity: Minor
        Found in pos/is4c-nf/install/conf/FormFactory.php - About 45 mins to fix

          Method textField has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function textField($name, $default_value='', $storage=Conf::EITHER_SETTING, $quoted=true, $attributes=array(), $area=false)
          Severity: Minor
          Found in pos/is4c-nf/install/conf/FormFactory.php - About 45 mins to fix

            Method checkboxField has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function checkboxField($name, $label, $default_value=0, $storage=Conf::EITHER_SETTING, $choices=array(0, 1), $attributes=array())
            Severity: Minor
            Found in pos/is4c-nf/install/conf/FormFactory.php - About 45 mins to fix

              Function writeInput has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function writeInput($name, $current_value, $storage)
    {
        if ($storage == Conf::INI_SETTING) {
            if (!is_numeric($current_value) && strtolower($current_value) !== 'true' && strtolower($current_value !== 'false')) {
                Conf::save($name, "'" . $current_value . "'");
              Severity: Minor
              Found in pos/is4c-nf/install/conf/FormFactory.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function sanitizeValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function sanitizeValue($current_value, $is_array, $quoted)
    {
        if (!$is_array && !$quoted) {
            // unquoted must be a number or boolean
            if (!is_numeric($current_value) && strtolower($current_value) !== 'true' && strtolower($current_value) !== 'false') {
              Severity: Minor
              Found in pos/is4c-nf/install/conf/FormFactory.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  private function sanitizeString($current_value)
    {
        // quoted must not contain single quotes
        $current_value = str_replace("'", '', $current_value);
        // must not start with backslash
              Severity: Major
              Found in pos/is4c-nf/install/conf/FormFactory.php and 1 other location - About 3 hrs to fix
              fannie/install/util.php on lines 330..344

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 143.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status