Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/lib/PrehLib.php

Summary

Maintainability
F
3 days
Test Coverage
D
64%

File PrehLib.php has 405 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2001, 2004 Wedge Community Co-op
Severity: Minor
Found in pos/is4c-nf/lib/PrehLib.php - About 5 hrs to fix

    Method omtr_ttl has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    static public function omtr_ttl() 
{
    // Must have gotten member number before totaling.
    if (CoreLocal::get("memberID") == "0") {
        return MiscLib::baseURL()."gui-modules/memlist.php";
    Severity: Major
    Found in pos/is4c-nf/lib/PrehLib.php - About 3 hrs to fix

      Method ttl has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      static public function ttl() 
{
    $ret = true;
    if (CoreLocal::get("memberID") == "0") {
        return MiscLib::baseURL()."gui-modules/memlist.php";
      Severity: Major
      Found in pos/is4c-nf/lib/PrehLib.php - About 2 hrs to fix

        Function omtr_ttl has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

        static public function omtr_ttl() 
{
    // Must have gotten member number before totaling.
    if (CoreLocal::get("memberID") == "0") {
        return MiscLib::baseURL()."gui-modules/memlist.php";
        Severity: Minor
        Found in pos/is4c-nf/lib/PrehLib.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method tender has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        static public function tender($right, $strl)
{
    $ret = array('main_frame'=>false,
        'redraw_footer'=>false,
        'target'=>'.baseHeight',
        Severity: Minor
        Found in pos/is4c-nf/lib/PrehLib.php - About 1 hr to fix

          Function ttl has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          static public function ttl() 
{
    $ret = true;
    if (CoreLocal::get("memberID") == "0") {
        return MiscLib::baseURL()."gui-modules/memlist.php";
          Severity: Minor
          Found in pos/is4c-nf/lib/PrehLib.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function tender has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          static public function tender($right, $strl)
{
    $ret = array('main_frame'=>false,
        'redraw_footer'=>false,
        'target'=>'.baseHeight',
          Severity: Minor
          Found in pos/is4c-nf/lib/PrehLib.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function runTotalActions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

          static private function runTotalActions()
{
    $ttlHooks = CoreLocal::get('TotalActions');
    if (is_array($ttlHooks)) {
        foreach($ttlHooks as $ttlClass) {
          Severity: Minor
          Found in pos/is4c-nf/lib/PrehLib.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method ageCheck has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          public static function ageCheck($requiredAge, $ret)
{
    $myUrl = MiscLib::baseURL();
    if (CoreLocal::get("cashierAge") < 18 && CoreLocal::get("cashierAgeOverride") != 1){
        $ret['main_frame'] = $myUrl."gui-modules/adminlogin.php?class=COREPOS-pos-lib-adminlogin-AgeApproveAdminLogin";
          Severity: Minor
          Found in pos/is4c-nf/lib/PrehLib.php - About 1 hr to fix

            Function ageCheck has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            public static function ageCheck($requiredAge, $ret)
{
    $myUrl = MiscLib::baseURL();
    if (CoreLocal::get("cashierAge") < 18 && CoreLocal::get("cashierAgeOverride") != 1){
        $ret['main_frame'] = $myUrl."gui-modules/adminlogin.php?class=COREPOS-pos-lib-adminlogin-AgeApproveAdminLogin";
            Severity: Minor
            Found in pos/is4c-nf/lib/PrehLib.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function percentDiscount has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            static public function percentDiscount($strl,$json=array()) 
{
    if ($strl == 10.01) {
        $strl = 10;
    }
            Severity: Minor
            Found in pos/is4c-nf/lib/PrehLib.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getTenderMods has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            static private function getTenderMods($right)
{
    $ret = array('COREPOS\\pos\\lib\\Tenders\\TenderModule');

    /**
            Severity: Minor
            Found in pos/is4c-nf/lib/PrehLib.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (CoreLocal::get("balance") < CoreLocal::get("memChargeTotal") && CoreLocal::get("memChargeTotal") > 0){
        if (CoreLocal::get('msgrepeat') == 0){
            CoreLocal::set("boxMsg",sprintf("<b>A/R Imbalance</b><br />
                Total AR payments $%.2f exceeds AR balance %.2f<br />",
                CoreLocal::get("memChargeTotal"),
            Severity: Major
            Found in pos/is4c-nf/lib/PrehLib.php and 1 other location - About 3 hrs to fix
            pos/is4c-nf/lib/TotalActions/ArOverpayAction.php on lines 48..61

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 142.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                if (CoreLocal::get("runningTotal") <= 4.00 ) {
        $totalBefore = CoreLocal::get("amtdue");
        $ret = Database::changeLttTaxCode("HST","GST");
        if ( $ret !== True ) {
            TransRecord::addcomment("$ret");
            Severity: Major
            Found in pos/is4c-nf/lib/PrehLib.php and 1 other location - About 2 hrs to fix
            pos/is4c-nf/lib/TotalActions/OntarioMealTaxRebateAction.php on lines 48..61

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 141.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status